-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extracted text for valkyrie and wings #6110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wings derivative creation. updated active_fedora_convertor t load extracted_text into fedora. modified derivative services to accept extracted text for wings derivatives. updated file_set indexer to save extracted_text_id_ssi. added a guard for the to_rdf Wings wrapper so that it cannot double wrap has_model.
…vera/hyrax into 5544_valkyrie_extracted_text
orangewolf
changed the title
Draft: extracted text for valkyrie and wings
extracted text for valkyrie and wings
Aug 9, 2023
aprilrieger
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renamed size and type to recorded_size and pcdm_use. use valkyrie for wings derivative creation. updated active_fedora_convertor t load extracted_text into fedora. modified derivative services to accept extracted text for wings derivatives. updated file_set indexer to save extracted_text_id_ssi. added a guard for the to_rdf Wings wrapper so that it cannot double wrap has_model.
Fixes
Fixes #5544
Summary
Present tense short summary (50 characters or less)
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Type of change (for release notes)
Add an appropriate
notes-*
label to the PR (or indicate here) that classifies this change.Choose from:
notes-major
Major Changes (Potentially breaking changes)notes-minor
New Features that are backward compatiblenotes-deprecation
Deprecationsnotes-bugfix
Bug Fixesnotes-valkyrie
Valkyrie Progressnotes-docs
Documentationnotes-container
Containerization related (Docker, Helm, etc)Detailed Description
More detailed description, if necessary. Try to be as descriptive as you can: even if you think that the PR content is obvious, it may not be obvious to others. Include tracebacks if helpful, and be sure to call out any bits of the PR that may be work-in-progress.
Description can have multiple paragraphs and you can use code examples inside:
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers