Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extracted text for valkyrie and wings #6110

Merged
merged 19 commits into from
Aug 9, 2023
Merged

Conversation

sephirothkod
Copy link
Contributor

renamed size and type to recorded_size and pcdm_use. use valkyrie for wings derivative creation. updated active_fedora_convertor t load extracted_text into fedora. modified derivative services to accept extracted text for wings derivatives. updated file_set indexer to save extracted_text_id_ssi. added a guard for the to_rdf Wings wrapper so that it cannot double wrap has_model.

Fixes

Fixes #5544

Summary

Present tense short summary (50 characters or less)

Guidance for testing, such as acceptance criteria or new user interface behaviors:

Type of change (for release notes)

Add an appropriate notes-* label to the PR (or indicate here) that classifies this change.

Choose from:

  • notes-major Major Changes (Potentially breaking changes)
  • notes-minor New Features that are backward compatible
  • notes-deprecation Deprecations
  • notes-bugfix Bug Fixes
  • notes-valkyrie Valkyrie Progress
  • notes-docs Documentation
  • notes-container Containerization related (Docker, Helm, etc)

Detailed Description

More detailed description, if necessary. Try to be as descriptive as you can: even if you think that the PR content is obvious, it may not be obvious to others. Include tracebacks if helpful, and be sure to call out any bits of the PR that may be work-in-progress.

Description can have multiple paragraphs and you can use code examples inside:

class PostsController
  def index
    respond_with Post.limit(10)
  end
end

Changes proposed in this pull request:

@samvera/hyrax-code-reviewers

… wings derivative creation. updated active_fedora_convertor t load extracted_text into fedora. modified derivative services to accept extracted text for wings derivatives. updated file_set indexer to save extracted_text_id_ssi. added a guard for the to_rdf Wings wrapper so that it cannot double wrap has_model.
@sephirothkod sephirothkod marked this pull request as draft July 12, 2023 23:59
@orangewolf orangewolf marked this pull request as ready for review August 9, 2023 05:10
@orangewolf orangewolf changed the title Draft: extracted text for valkyrie and wings extracted text for valkyrie and wings Aug 9, 2023
@orangewolf orangewolf merged commit 50e1a25 into main Aug 9, 2023
@orangewolf orangewolf deleted the 5544_valkyrie_extracted_text branch August 9, 2023 14:57
@dlpierce dlpierce added the notes-valkyrie Release Notes: Valkyrie specific label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-valkyrie Release Notes: Valkyrie specific valk-rc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extracted Text derivative generation doesn't work for Valkyrie resources.
4 participants