add Hyrax::FileSet to FileSetSearchBuilder model search filter #6083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs
Fixes
Fixes #5796
Summary
Adds
Hyrax::FileSet
to theFileSet
search builder model filter so thatFileSet
-related searches work in both ActiveFedora and Valkyrie Hyrax apps.Guidance for testing, such as acceptance criteria or new user interface behaviors:
.koppie
app locally.dassie
appType of change (for release notes)
Detailed Description
When running a Valkyrie-based Hyrax app, the model is indexed in Solr as "Hyrax::FileSet" (
has_model_ssim:"Hyrax::FileSet"
). In an ActiveFedora-based Hyrax app, by contrast, the model is indexed as just "FileSet" (has_model_ssim:FileSet
).Before this change, we were only handling the latter in FileSet-related searches. This was breaking the FileSet show page in Valkyrie-based Hyrax apps since the FileSet being searched for was being filtered out.
Change working in .koppie
Change working in .dassie
Changes proposed in this pull request:
Hyrax::FileSet
to theHyrax::FileSetSearchBuilder
models query filter@samvera/hyrax-code-reviewers