Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Hyrax::FileSet to FileSetSearchBuilder model search filter #6083

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

bkiahstroud
Copy link
Contributor

Refs

Fixes

Fixes #5796

Summary

Adds Hyrax::FileSet to the FileSet search builder model filter so that FileSet-related searches work in both ActiveFedora and Valkyrie Hyrax apps.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  1. Spin up the .koppie app locally
  2. Login as an admin
  3. Navigate to Dashboard > Works
  4. Click the "Add New Work" button. Select GenericWork. Click "Create work"
  5. Fill out the required metadata fields
  6. Under the Files tab, upload a file
  7. Click "Public" under the Visibility sidebar
  8. Check the deposit agreement and click "Save"
  9. On the newly-created Work's details page, click the title of the uploaded file under the Items section
  10. Verify that you can see the File's details page (i.e. you do not get redirected to the homepage with an "unauthorized access" message)
  11. Repeat steps 2-10 locally with the .dassie app

Type of change (for release notes)

  • Major Changes (Potentially breaking changes)
  • New Features
  • Deprecations
  • Bug Fixes
  • Valkyrie Progress
  • Documentation
  • Containerization

Detailed Description

When running a Valkyrie-based Hyrax app, the model is indexed in Solr as "Hyrax::FileSet" (has_model_ssim:"Hyrax::FileSet"). In an ActiveFedora-based Hyrax app, by contrast, the model is indexed as just "FileSet" (has_model_ssim:FileSet).

Before this change, we were only handling the latter in FileSet-related searches. This was breaking the FileSet show page in Valkyrie-based Hyrax apps since the FileSet being searched for was being filtered out.

Change working in .koppie

File Set large jpg ID 1950ae52-41c2-4222-abdb-7b034d89aee5 Koppie 2023-05-31 at 5 45 21 PM

Change working in .dassie

File cat_scan jpg ID s1784k724 Hyrax 2023-05-31 at 5 46 05 PM

Changes proposed in this pull request:

  • Add Hyrax::FileSet to the Hyrax::FileSetSearchBuilder models query filter

@samvera/hyrax-code-reviewers

When running a Valkyrie-based Hyrax app, the model is indexed in Solr as "Hyrax::FileSet" (`has_model_ssim:"Hyrax::FileSet"`). In an ActiveFedora-based Hyrax app, by contrast, the model is indexed as just "FileSet" (`has_model_ssim:FileSet`).

Before this change, we were only handling the latter in FileSet-related searches. This was breaking the FileSet show page in Valkyrie-based Hyrax apps since the FileSet being searched for was being filtered out.

This change adds "Hyrax::FileSet" to the model search filter so that it works for both kinds of Hyrax apps.
@alishaevn alishaevn merged commit 24f0a4f into main Jun 1, 2023
@alishaevn alishaevn deleted the i5796-valkyrie-file-details-page-not-accessible branch June 1, 2023 17:28
@dlpierce dlpierce added the notes-valkyrie Release Notes: Valkyrie specific label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-valkyrie Release Notes: Valkyrie specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Details page not accessible
4 participants