Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wings] Add switch to use valkyrie in the solr service #3857

Merged
merged 2 commits into from
Jun 28, 2019
Merged

[wings] Add switch to use valkyrie in the solr service #3857

merged 2 commits into from
Jun 28, 2019

Conversation

hackartisan
Copy link
Contributor

advances #3800

@hackartisan hackartisan mentioned this pull request Jun 27, 2019
Merged
no-reply
no-reply reviewed Jun 27, 2019
View reviewed changes
Copy link
Contributor

@no-reply no-reply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment on the plan for flipping this switch?

Is the idea to change all of these use_valkyrie flags at once, at some future date? Is that a per-application decision?

@hackartisan
Copy link
Contributor Author

@no-reply updated with a global switch as we discussed. let me know if it's not what you had imagined.

@hackartisan hackartisan mentioned this pull request Jun 27, 2019
Merged
no-reply
no-reply approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@no-reply no-reply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic!

@no-reply no-reply merged commit a6eb188 into master Jun 28, 2019
@elrayle elrayle mentioned this pull request Aug 2, 2019
Closed
@elrayle elrayle deleted the 3800-valkyrie-solr-service branch August 27, 2019 13:00
jeremyf added a commit that referenced this pull request Feb 7, 2024
@jeremyf
🐛 Restore qt: 'standard' to SolrService
2b278b2 
In `ActiveFedora::SolrService` we always assign the `qt: 'standard'`.[1]

However, with [this old commit][1] we dropped passing the `qt:
'standard'` when we had `use_valkyrie` of true.

We discovered this bug when upgrading Hyku and Bulkrax to Hyrax v3.x and
some.

Closes #6676

Related to:

- #3857

[1]:https://github.com/samvera/active_fedora/blob/8e7d365a087974b4ff9b9217f792c0c049789de6/lib/active_fedora/solr_service.rb#L40-L48
[2]:be6104f
@jeremyf jeremyf mentioned this pull request Feb 7, 2024
Merged
jeremyf added a commit that referenced this pull request Feb 7, 2024
@jeremyf
🐛 Restore qt: 'standard' to SolrService
2d1a5d6 
In `ActiveFedora::SolrService` we always assign the `qt: 'standard'`.[1]

However, with [this old commit][1] we dropped passing the `qt:
'standard'` when we had `use_valkyrie` of true.

We discovered this bug when upgrading Hyku and Bulkrax to Hyrax v3.x and
some.

Closes #6676

Related to:

- #3857

[1]:https://github.com/samvera/active_fedora/blob/8e7d365a087974b4ff9b9217f792c0c049789de6/lib/active_fedora/solr_service.rb#L40-L48
[2]:be6104f
jeremyf added a commit that referenced this pull request Feb 7, 2024
@jeremyf
🐛 Restore qt: 'standard' to SolrService
3462159 
In `ActiveFedora::SolrService` we always assign the `qt: 'standard'`.[1]

However, with [this old commit][1] we dropped passing the `qt:
'standard'` when we had `use_valkyrie` of true.

We discovered this bug when upgrading Hyku and Bulkrax to Hyrax v3.x and
some.

Closes #6676

Related to:

- #3857

[1]:https://github.com/samvera/active_fedora/blob/8e7d365a087974b4ff9b9217f792c0c049789de6/lib/active_fedora/solr_service.rb#L40-L48
[2]:be6104f
jeremyf added a commit that referenced this pull request Feb 7, 2024
@jeremyf
🐛 Restore qt: 'standard' to SolrService
190550a 
In `ActiveFedora::SolrService` we always assign the `qt: 'standard'`.[1]

However, with [this old commit][1] we dropped passing the `qt:
'standard'` when we had `use_valkyrie` of true.

We discovered this bug when upgrading Hyku and Bulkrax to Hyrax v3.x and
some.

Closes #6676

Related to:

- #3857

[1]:https://github.com/samvera/active_fedora/blob/8e7d365a087974b4ff9b9217f792c0c049789de6/lib/active_fedora/solr_service.rb#L40-L48
[2]:be6104f
jeremyf added a commit that referenced this pull request Feb 7, 2024
@jeremyf
🐛 Restore qt: 'standard' to SolrService
8c3f32d 
In `ActiveFedora::SolrService` we always assign the `qt: 'standard'`.[1]

However, with [this old commit][1] we dropped passing the `qt:
'standard'` when we had `use_valkyrie` of true.

We discovered this bug when upgrading Hyku and Bulkrax to Hyrax v3.x and
some.

Closes #6676

Related to:

- #3857

[1]:https://github.com/samvera/active_fedora/blob/8e7d365a087974b4ff9b9217f792c0c049789de6/lib/active_fedora/solr_service.rb#L40-L48
[2]:be6104f
jeremyf added a commit that referenced this pull request Feb 7, 2024
@jeremyf
🐛 Restore qt: 'standard' to SolrService
78abeaa 
In `ActiveFedora::SolrService` we always assign the `qt: 'standard'`.[1]

However, with [this old commit][1] we dropped passing the `qt:
'standard'` when we had `use_valkyrie` of true.

We discovered this bug when upgrading Hyku and Bulkrax to Hyrax v3.x and
some.

Closes #6676

Related to:

- #3857

[1]:https://github.com/samvera/active_fedora/blob/8e7d365a087974b4ff9b9217f792c0c049789de6/lib/active_fedora/solr_service.rb#L40-L48
[2]:be6104f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@no-reply no-reply no-reply approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hackartisan @no-reply