Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility options for Embargo don't expand on batch create form #930

Closed
hortongn opened this issue May 9, 2017 · 3 comments · Fixed by #986
Closed

Visibility options for Embargo don't expand on batch create form #930

hortongn opened this issue May 9, 2017 · 3 comments · Fixed by #986

Comments

@hortongn
Copy link
Member

hortongn commented May 9, 2017

Descriptive summary

When a user is on the batch create form and clicks the radio button for "Embargo" the form does not expand to reveal the "Restricted to..." or "then open it up to.." options like it does on the single work form.

We experienced the bug on 1.0.0.rc1, but it looks like the bug is still in master as well.

Expected behavior

Clicking on the "Embargo" radio button in the Visibility section of the batch create form should reveal additional form options.

Actual behavior

Clicking on the "Embargo" radio button in the Visibility section of the batch create form has no effect other than selecting the radio button itself.

Steps to reproduce the behavior

  1. Go to the form to create a new batch work
  2. Click on the "Embargo" radio button

Related work

University of Cincinnati has fixed this locally here: https://github.com/uclibs/scholar_uc/pull/1373/files

The problem is that the batch form doesn't include the data-behavior="work-form" in the

tag. So the JS that expands the options doesn't know what to act on.

@mjgiarlo
Copy link
Member

mjgiarlo commented May 9, 2017

@hortongn What tag/branch/commit are you seeing this with?

Thanks for reporting this, and for linking to your fix!

@mjgiarlo mjgiarlo added the ready label May 9, 2017
@mjgiarlo mjgiarlo added this to the 2.0.0 milestone May 9, 2017
@hortongn
Copy link
Member Author

@mjgiarlo I've updated the bug description with the version we were using.

@hortongn hortongn self-assigned this May 15, 2017
@mjgiarlo
Copy link
Member

Thanks for taking this on, @hortongn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants