Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Valkyrie/Fedora some predicates in the Fedora interface are "http://example.com/predicate/" #6332

Closed
1 task done
dlpierce opened this issue Sep 28, 2023 · 1 comment · Fixed by #6338
Closed
1 task done

In Valkyrie/Fedora some predicates in the Fedora interface are "http://example.com/predicate/" #6332

dlpierce opened this issue Sep 28, 2023 · 1 comment · Fixed by #6338
Assignees
@bwatson78
Labels
valkyrie-fedora

Comments

@dlpierce
Copy link
Contributor

dlpierce commented Sep 28, 2023 •
edited by bwatson78
Loading

Descriptive summary

Properties stored using the fedora metadata adapter have the predicate http://example.com/predicate/

Steps to reproduce the behavior in User Interface (UI)

  1. Load sirenia (koppie with fedora metadata/storage adapters)
  2. Create a monograph
  3. Examine fedora rest interface for the monograph

Actual behavior (include screenshots if available)

Screenshot_20230928_113338

Acceptance Criteria/Expected Behavior

  • Appropriate predicates are displayed for each property

Rationale (for feature request only)

Fedora data should more closely match data created by a ActiveFedora backed hyrax

Related work

#6331
@bwatson78 bwatson78 self-assigned this Sep 29, 2023
bwatson78 added a commit that referenced this issue Oct 3, 2023
@bwatson78
Adds a permissive schema to the Fedora Valkyrie adapter (#6332).
e4d6216
@bwatson78 bwatson78 mentioned this issue Oct 3, 2023
Merged
dlpierce pushed a commit that referenced this issue Oct 6, 2023
@bwatson78 @dlpierce
Adds a permissive schema to the Fedora Valkyrie adapter (#6332).
ab2d9af
dlpierce added a commit that referenced this issue Oct 6, 2023
@bwatson78 @dlpierce
Adds a permissive schema to the Fedora Valkyrie adapter (#6332). (#6338)
c5db7f6 
* Adds a permissive schema to the Fedora Valkyrie adapter (#6332).

* convert keys to symbols.

* Adds internal attributes.

* Adds warning of multiple assignments.

* Include predicate details in warning and only warn if the predicates do not match; sort internals

---------

Co-authored-by: Daniel Pierce <[email protected]>
@jlhardes
Copy link
Contributor

The properties used on a Monograph work in Sirenia no longer include http://example.com/predicate/ and are either mapped as expected for a work in Hyrax or using http://hyrax-example.com/predicate so I think the changes have taken effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwatson78 bwatson78

Labels
valkyrie-fedora
Projects
Hyrax-Valkyrization
Status: DONE
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds a permissive schema to the Fedora Valkyrie adapter (#6332). samvera/hyrax
3 participants
@dlpierce @jlhardes @bwatson78