Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new sub-collection leads to NoMethodError in Hyrax::Dashboard::NestCollectionsController#create_collection_under #5492

Closed
MPLSFedResearchTZ opened this issue Mar 3, 2022 · 10 comments · Fixed by #5580
Assignees
Labels
Collection impacts the Collection part of PCDM Model priority valkyrization

Comments

@MPLSFedResearchTZ
Copy link

Descriptive summary

Clicking "Create new collection as subcollection" gives rise to error page of "NoMethodError in Hyrax::Dashboard::NestCollectionsController#create_collection_under".

Steps to reproduce the behavior

  1. Go to collection editing page.
  2. Clicking "Create new collection as subcollection"
  3. Error page appears
@elrayle
Copy link
Contributor

elrayle commented Mar 7, 2022

Related issue #5449. Perhaps duplicate but appears to be getting NoMethodError for #create_collection_under instead of #find.

@elrayle elrayle added Collection impacts the Collection part of PCDM Model valkyrization and removed duplicate labels Mar 7, 2022
@elrayle elrayle self-assigned this Mar 16, 2022
@blancoj blancoj assigned blancoj and unassigned elrayle Mar 25, 2022
@jlhardes
Copy link
Contributor

jlhardes commented Apr 6, 2022

This error is still occurring on nurax-pg:

Screen Shot 2022-04-06 at 5 11 07 PM

Steps to reproduce the behavior

  • From Dashboard -> Collections create a collection of type "nesting only"
  • From Dashboard -> Collections, click the title of the collection
  • Click Create new collection as subcollection (this is where the error occurs that is in the screenshot)

@jlhardes jlhardes reopened this Apr 6, 2022
@no-reply
Copy link
Contributor

@jlhardes i'm confused if this is an issue with nurax-pg / valkyrie support, or if it's a base hyrax issue.

i don't think any of the NestCollectionsController supports valkyrie. AFAIK, this is the only thing not passing the full test suite when using a valkyrie collection model.

this was coming up to the top of my ToDo list, but i'm concerned about taking that work on if the controller is broken against the ActiveFedora branch.

@jlhardes
Copy link
Contributor

This was from testing nurax-pg so it is valkyrie-specific. I just tested again and the error is still occurring on nurax-pg. Does that help?

@blancoj
Copy link
Contributor

blancoj commented Jun 29, 2022

@jlhardes and @no-reply I'm taking a look at it again.

@gamontoya
Copy link

@cjcolvar @blancoj I'm still seeing the error (testing on nurax-pg)

5492

@cjcolvar
Copy link
Member

The fix hasn't been merged and deployed to nurax-pg yet. I can tag you for retesting once it is deployed.

@eporter23
Copy link
Contributor

I was able to successfully create a sub collection within a User Collection type that I had previously created, using the original steps in the ticket description. I am seeing another error when trying to open the All Collections tab within the Dashboard however.
Screen Shot 2023-01-23 at 1 29 03 PM

Screen Shot 2023-01-23 at 1 29 18 PM

@jlhardes
Copy link
Contributor

I think this sub-collection issue is fixed. It works for me testing locally on koppie the same as you reported. The All Collections tab on nurax-pg is not working when logged in as an admin user. Testing locally on koppie as an admin user, the All Collections tab is working so it might be something specific to indexing on nurax-pg?

@eporter23
Copy link
Contributor

Thanks @jlhardes I was wondering if it was a nurax-pg specific error since it seemed to reference a specific Collection Type id being missing. I'll go ahead and close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Collection impacts the Collection part of PCDM Model priority valkyrization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants