Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply font doesn't work with multiple font pickers #7

Closed
jede opened this issue Apr 16, 2019 · 1 comment
Closed

Apply font doesn't work with multiple font pickers #7

jede opened this issue Apr 16, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@jede
Copy link

jede commented Apr 16, 2019

Hi,

Thanks for a great library! I noticed that this line:

activeFontStylesheet.replaceChild(styleNode, activeFontStylesheet.childNodes[0]);

Always replaces the whole style. This unfortunately leads to that two different font pickers will overwrite each others styles. So only one font can be applied at once. I guess its possible to work around by just using inline styles, but it would of course be easier wil the apply-font class.

fontpicker

@samuelmeuli
Copy link
Owner

samuelmeuli commented May 11, 2019

Thanks for looking into this! It should be fixed in the next release :)

@samuelmeuli samuelmeuli added the bug Something isn't working label May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants