fix: IsUrl for 2nd version of pydantic #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 12 12
Lines 813 815 +2
Branches 146 146
=======================================
+ Hits 811 813 +2
Misses 2 2
Continue to review full report in Codecov by Sentry.
|
samuelcolvin
reviewed
Sep 3, 2023
| @@ -260,13 +262,15 @@ def equals(self, other: Any) -> bool: | |||
| parsed = self.parse_obj_as(self.url_type, other) | |||
| except self.ValidationError: | |||
| raise ValueError('Invalid URL') | |||
|
|
|||
| equal = parsed == other if self.pydantic_version < '2' else parsed.unicode_string() == other | |||
There was a problem hiding this comment.
we'll have problems when pydantic hits V10!
There was a problem hiding this comment.
I fixed this problem here: #80 😄
|
thanks so much. |
The issue is still open. I wonder if the word 'issue' threw off github? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #72