Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pypy #36

Merged
merged 4 commits into from
Apr 28, 2022
Merged

Support pypy #36

merged 4 commits into from
Apr 28, 2022

Conversation

samuelcolvin
Copy link
Owner

@samuelcolvin samuelcolvin commented Apr 28, 2022 •
edited
Loading

fix #34.

Except direct class usage e.g.:

  • assert 1 == IsInt doesn't work
  • but, assert 1 == IsInt() does

@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

Merging #36 (a0fce3a) into main (f6e0d13) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          660       660           
  Branches       167       167           
=========================================
  Hits           660       660
Impacted Files Coverage Δ
dirty_equals/_dict.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e0d13...a0fce3a. Read the comment docs.

@samuelcolvin samuelcolvin mentioned this pull request Apr 28, 2022
Closed
mgorny
mgorny approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I can confirm that the tests pass now.

@samuelcolvin samuelcolvin merged commit 2d3c0e5 into main Apr 28, 2022
@samuelcolvin samuelcolvin deleted the pypy branch April 28, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numerous test failures with pypy3.9
2 participants
@samuelcolvin @mgorny