Add IsDate feature #20
Conversation
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 559 584 +25
Branches 145 153 +8
=========================================
+ Hits 559 584 +25
Continue to review full report at Codecov.
|
dirty_equals/_datetime.py
Outdated
| lt: Optional[date] = None, | ||
| ge: Optional[date] = None, | ||
| le: Optional[date] = None, | ||
| unix_number: bool = False, |
There was a problem hiding this comment.
I think we should remove this option, it doesn't really make sense to use unix timestamps with dates.
dirty_equals/_datetime.py
Outdated
| """ | ||
|
|
||
| if isinstance(delta, timedelta): | ||
| delta = timedelta(days=delta.days) |
There was a problem hiding this comment.
perhaps a comment here explaining why this is necessary.
dirty_equals/_datetime.py
Outdated
| """ | ||
| Args: | ||
| approx: A value to approximately compare to. | ||
| delta: The allowable different when comparing to the value to `approx`, if omitted 2 seconds is used, |
There was a problem hiding this comment.
not sure 2 seconds really makes much sense here, I guess should be zero.
dirty_equals/_datetime.py
Outdated
| ) | ||
|
|
||
| def prepare(self, other: Any) -> date: | ||
| if isinstance(other, date): |
There was a problem hiding this comment.
😆 potential mistake here! datetime is a subclass of date, so isinstance(datetime.now(), date) is True.
| if isinstance(other, date): | |
| if type(other) == date: |
Is probably simplest.
| format_string: Optional[str] = None, | ||
| ): | ||
|
|
||
| """ |
There was a problem hiding this comment.
you need to add IsDate to the docs, probably add it after this line.
There was a problem hiding this comment.
only docs remained in todo. I'll do it in an available time.
There was a problem hiding this comment.
this still needs adding, should be two lines.
|
@samuelcolvin Thanks for your reviews and valuable recommendations. I'll prepare a fix for bugs you found and add IsToday similar to IsNow. |
| format_string: Optional[str] = None, | ||
| ): | ||
|
|
||
| """ |
There was a problem hiding this comment.
this still needs adding, should be two lines.
|
thanks so much. |
No description provided.