Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create multiple issues #19

Open
fabaff opened this issue Apr 23, 2022 · 4 comments
Open

Don't create multiple issues #19

fabaff opened this issue Apr 23, 2022 · 4 comments

Comments

@fabaff
Copy link

fabaff commented Apr 23, 2022

For the same failure the script creates new issues with every run it seems, e. g., like #169873.

If there is already an open issue then the script should pass that step or update the already present issue.

@SuperSandro2000
Copy link

Related #17 (comment)

@samuela
Copy link
Owner

samuela commented Apr 25, 2022

Hey guys, sorry for the duplicate issues! I'm actively trying to figure out the best way to dedup issues. The current solution is to check for existing issues (open or closed) that either

  • contain the same last 10 log lines, timing info removed, or
  • have the same drv hash

But unfortunately every time I update the deduplication hashes, it then causes pre-existing issues to not be recognized. So although I think the current system does a decent job, it did take a decent amount of trial and error to get here. I'm really sorry about the spam! I try to do my best to triage any issues as they get generated.

@samuela
Copy link
Owner

samuela commented Apr 25, 2022

Also, if you have any other ideas to improve the issue dedup'ing hashes, I'd be genuinely curious to hear! I'm open to any improvements to the system.

@SuperSandro2000
Copy link

I would suggest to use an extra repository right now. Then you can fidel with the code, test things and try to get the early bugs squashed out. If everything is battle tested and working to your likings it can be put live on nixpkgs. This way we can keep the disruption low and don't ping people unnecessarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants