Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test packages on the staging, staging-next branches as well as master #18

Open
samuela opened this issue Apr 18, 2022 · 3 comments
Open

Comments

@samuela
Copy link
Owner

samuela commented Apr 18, 2022

It's often the case that large, sweeping changes are made on staging/staging-next that break builds. This is problematic due to the massive number of commits between successful and broken versions, making bisecting very annoying. It would be nice to run all of the canary builds on all three branches: master, staging, staging-next.

@SuperSandro2000
Copy link

You don't need to bisect builds. Most if not all of the time it is more time effective to take a look at the error and figure out whats wrong from there.

Also building staging all the time is a bad idea because you are going to compile a lot of stdenvs and compilers.

@samuela
Copy link
Owner Author

samuela commented Apr 22, 2022

You don't need to bisect builds. Most if not all of the time it is more time effective to take a look at the error and figure out whats wrong from there.

I've found bisecting to be useful in a number of scenarios. If nothing else, it allows me to go to the author of the breakage with 100% certainty that it was their change that broke the build.

Also building staging all the time is a bad idea because you are going to compile a lot of stdenvs and compilers.

Agreed, but how else do you propose I address the issues raised in this post?

@SuperSandro2000
Copy link

Agreed, but how else do you propose I address the issues raised in this post?

I would suggest to build python-updates and staging-next when the PR is older than a day or two to make sure you are not compiling the world which can take 12 hours.

it allows me to go to the author of the breakage with 100% certainty that it was their change that broke the build.

Well, yes, that true. Maybe I fiddled to much with python packages that I gave up on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants