Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes announce local network addresses #86

Open
JoshuaCWebDeveloper opened this issue Nov 17, 2022 · 1 comment
Open

Nodes announce local network addresses #86

JoshuaCWebDeveloper opened this issue Nov 17, 2022 · 1 comment

Comments

@JoshuaCWebDeveloper
Copy link
Collaborator

#59 Reports 4 big inefficiencies with our libp2p network. Problem number 1) is that libp2p attempts to connect to a bunch of addresses that don't exist rather than attempting to connect to the addresses in the bootstrap list that it is given.

This problem seems sporadic, but I think I have tracked it down to each libp2p node announcing these no-op local addresses to the network. The client receives these announced addresses from each node in the network and attempts to use them to connect to the node.

Nodes should not announce addresses that they can't be reached by. I believe the way to prevent this is to specify an announceFilter: libp2p/js-libp2p#769 (specifying the announce config only adds addresses, not subtracts them).

@JoshuaCWebDeveloper
Copy link
Collaborator Author

Additional client side context: #59 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant