Changing Timezone parameters

[javexed]

Changing timezone parameters was rather difficult. If you do it wrong, the gitlab container won't come up and there isn't much of an error. Could be mitigated with a bit better documentation. For example, to convert to Eastern standard time:
TZ=Asia/Kolkata -> TZ=America/New_York
GITLAB_TIMEZONE=Kolkata -> GITLAB_TIMEZONE=EST

[LaurensRietveld]

Some more info: when you use a slash in the GITLAB_TIMEZONE, you'll get the following error:
sed: -e expression #1, char 30: unknown option to 's'

Problem occurs because the slash isnt escaped before passing it on to sed. No problem with me to use another timezone notation, but would be good to document about allowed timezone notations (took some time locating the error)

[sameersbn]

@LaurensRietveld Its already documented in https://github.com/sameersbn/docker-gitlab#available-configuration-parameters

[LaurensRietveld]

How I interpreted that page was that Europe/Amsterdam was allowed (Amsterdam as well, which is mapped to Europe/Amsterdam).
Is that correct? Because the issue here is with the Europe/Amsterdam TZ definition

[sameersbn]

You should use the mapping key. So if you want to set the rails timezone as Europe/Amsterdam, then according to http://api.rubyonrails.org/classes/ActiveSupport/TimeZone.html you should set GITLAB_TIMEZONE=Amsterdam

[umputun]

For central time i have found "Central Time (US & Canada)" => "America/Chicago". Using the key leads to an error: "ArgumentError: Invalid Timezone: "Central Time (US {{GITLAB_TIMEZONE}} Canada)"

[michaelryanmcneill]

I'm having basically the same issue as @umputun. I'm trying to use Eastern Time (US & Canada) which bombs out on creation with the error: ArgumentError: Invalid Timezone: Eastern Time (US {{GITLAB_TIMEZONE}} Canada) I was able to get past this by escaping the special characters: GITLAB_TIMEZONE=Eastern Time \(US \& Canada\)

[sameersbn]

The & character is now automatically escaped. If you have manually escaped the & character, then you need to remove it in versions > 8.1.x.

[k-dahl]

Ran into this today - may be something worth adding to the 'Upgrade' portion of the readme?

[sameersbn]

these changes are logged in #39

[k-dahl]

@sameersbn Awesome, I hadn't seen that - thanks!