Skip to content

Commit

Permalink
workflows: disable cockroach-microbench-ci step for pull requests
Browse files Browse the repository at this point in the history
This change disbales the CI step for pull requests but this still runs
for push step into the target branch. Also the count of the
microbenchmarks are increased to get more robust results.

Epic: none

Release note: None
  • Loading branch information
sambhav-jain-16 committed Aug 21, 2024
1 parent f1a5aa8 commit e2b7b6c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/github-actions-essential-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,8 @@ jobs:
if: always()
cockroach-microbench-ci:
runs-on: [ self-hosted, basic_runner_group ]
# TODO(sambhav-jain-16): enable this for pull requests also
if: ${{ github.event_name == 'push' }}
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion build/github/cockroach-microbench-ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ bazel test //pkg/sql/tests:tests_test \
--test_sharding_strategy=disabled \
--test_arg=-test.cpu --test_arg=1 \
--test_arg=-test.v \
--test_arg=-test.count=4 \
--test_arg=-test.count=10 \
--test_arg=-test.benchmem \
--crdb_test_off \
--test_output=all > "$log_output_file_path"
Expand Down

0 comments on commit e2b7b6c

Please sign in to comment.