From d0cd9ba735617bf78f3237a6bb7b60f962af5415 Mon Sep 17 00:00:00 2001 From: Andrew Baptist Date: Thu, 5 Dec 2024 15:10:58 -0500 Subject: [PATCH] rpc: increase timeout for TestClockOffsetInPingRequest Previously this test had the `RPCHeartbeatInterval` and `RPCHeartbeatTimeout` both set at 100ms. Normally the `RPCHeartbeatTimeout` is set at 3x the interval. During race builds this provides enough extra cushion that the test should pass. Epic: none Fixes: #136703 Release note: None --- pkg/rpc/context_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/rpc/context_test.go b/pkg/rpc/context_test.go index 0eda6956f1cc..5c65bf6ca708 100644 --- a/pkg/rpc/context_test.go +++ b/pkg/rpc/context_test.go @@ -202,7 +202,7 @@ func testClockOffsetInPingRequestInternal(t *testing.T, clientOnly bool) { clientOpts := opts // Experimentally, values below 50ms seem to incur flakiness. clientOpts.RPCHeartbeatInterval = 100 * time.Millisecond - clientOpts.RPCHeartbeatTimeout = 100 * time.Millisecond + clientOpts.RPCHeartbeatTimeout = 200 * time.Millisecond clientOpts.ClientOnly = clientOnly clientOpts.OnOutgoingPing = func(ctx context.Context, req *PingRequest) error { select {