Invoke twice CustomErrorHandler

[itivanov]

With this setup error handler is called twice

app := fiber.New(fiber.Config{
    ErrorHandler: CustomErrorHandler,
})

...

func CustomErrorHandler(c *fiber.Ctx, err error) error {
	fmt.Println(err)

	code := fiber.StatusInternalServerError

	var e *fiber.Error
	if errors.As(err, &e) {
		code = e.Code
	}

	c.Set(fiber.HeaderContentType, fiber.MIMETextPlainCharsetUTF8)

	return c.Status(code).SendString(err.Error())
}

[KScaesar]

I have the same issue.

slog-fiber Retrieve errHandler = c.App().ErrorHandler

slog-fiber/middleware.go

Lines 110 to 119 in bf0203e

	func NewWithConfig(logger *slog.Logger, config Config) fiber.Handler {
	var (
	once sync.Once
	errHandler fiber.ErrorHandler
	)
	return func(c *fiber.Ctx) error {
	once.Do(func() {
	errHandler = c.App().ErrorHandler
	})

after error handler execue, it should override the original err

slog-fiber/middleware.go

Lines 134 to 139 in bf0203e

	err := c.Next()
	if err != nil {
	if err := errHandler(c, err); err != nil {
	_ = c.SendStatus(fiber.StatusInternalServerError) //nolint:errcheck
	}
	}

FIX:
(X) if err := errHandler(c, err); err != nil {
(O) if err = errHandler(c, err); err != nil {

[samber]

@KScaesar i just made a fix in 1.16.3. Can you test it please ?

[KScaesar]

@KScaesar i just made a fix in 1.16.3. Can you test it please ?

nice fix!

The error handling in version 1.16.3 will only occur once.