Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ping/pong support #14

Open
samalone opened this issue Dec 11, 2023 · 0 comments
Open

Restore ping/pong support #14

samalone opened this issue Dec 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@samalone
Copy link
Owner

The automated ping/pong support that was in the code briefly is no longer working, and should probably be restored.

The goal of ping/pong is to:

  1. Keep the network connection live.
  2. Detect network problems early, so reconnect attempts can be started proactively.

It never really achieved the second goal, probably because there was no timeout waiting for the pong. Even when the phone is in airplane mode, the ping would hang for a long time before returning an error.

I believe that Vapor has good ping support. Perhaps that code could inspire a solution, or we could even consider adopting their WebSocket library.

@samalone samalone added the enhancement New feature or request label Dec 11, 2023
@samalone samalone changed the title Reinstate ping/pong support Restore ping/pong support Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant