You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
StartMonitorEvents takes a callback, and a channel, and untyped args. It spins up a new goroutine per call, but shares an atomic to allow StopAllMonitorEvents to work. The whole thing just seems very messy.
The Start/Stop can go away. Internally a single HTTP stream can be used for all the Watchers. Each Watcher can provide a Close so a global Stop/Close isn't necessary.
Thoughts?
The text was updated successfully, but these errors were encountered:
StartMonitorEvents
takes a callback, and a channel, and untyped args. It spins up a new goroutine per call, but shares an atomic to allowStopAllMonitorEvents
to work. The whole thing just seems very messy.https://github.com/go-fsnotify/fsnotify may be a good source of inspiration here.
Would prefer an API along the lines of:
The Start/Stop can go away. Internally a single HTTP stream can be used for all the Watchers. Each Watcher can provide a Close so a global Stop/Close isn't necessary.
Thoughts?
The text was updated successfully, but these errors were encountered: