[DOCS] reactors should have unquie state ids to avoid nameing conflicts.

[whytewolf]

Description
currently the documentation for reactors does not call out that reactors should have unique state ids. this normally might not be a problem in most cases. however it is possible to have a name collision. which will cause reactors to silently fail or not run.

the possibility of name collision is called out in the code. at

salt/salt/utils/process.py

Lines 448 to 450 in 4ec0429

	# intentionally not called "apply_async" since we aren't keeping track of
	# the return at all, if we want to make this API compatible with multiprocessing
	# threadpool we can in the future, and we won't have to worry about name collision

Suggested Fix
document the possibility of name collision causing dropped reactors.

Location or format of documentation
https://docs.saltproject.io/en/latest/topics/reactor/index.html

Additional context
This can cause an almost undetectable issue where a reactor will just not run and no error messages being displayed.

[OrangeDog]

Wouldn't they be reactor ids, not state ids?

I'd also suggest that it's a bug that duplicates are not detected as they are with states.

[whytewolf]

While i would agree that name makes more sense. the chunk is still called a state. and the file is still an sls module.

Also. currently is it is expected behavior. and commented as such in the code.