Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GCE metadata grain code is overly complex #62878

Open
3 of 9 tasks
jonbenning opened this issue Oct 13, 2022 · 1 comment
Open
3 of 9 tasks

[BUG] GCE metadata grain code is overly complex #62878

jonbenning opened this issue Oct 13, 2022 · 1 comment

Comments

@jonbenning
Copy link
Contributor

Description
The gce metadata grain code was likely heavily influenced by the AWS EC2 grains, and utilizes complex recursion logic that is not needed in GCP.

Setup
There is nothing presently broken in the current metadata_gce.py code, but its difficult to read, and could be far simpler.

Please be as specific as possible and give set-up details.

  • on-prem machine
  • VM (Virtualbox, KVM, etc. please specify)
  • VM running on a cloud service, please be explicit and add details
  • container (Kubernetes, Docker, containerd, etc. please specify)
  • or a combination, please be explicit
  • jails if it is FreeBSD
  • classic packaging
  • onedir packaging
  • used bootstrap to install

Steps to Reproduce the behavior
(Include debug logs if possible and relevant)

Expected behavior
Code should retrieve all available (non-sensitive) metadata from the gcp metadata service and create grains accordingly

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

@jonbenning jonbenning added Bug broken, incorrect, or confusing behavior needs-triage labels Oct 13, 2022
@welcome
Copy link

welcome bot commented Oct 13, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@OrangeDog OrangeDog added tech-debt and removed Bug broken, incorrect, or confusing behavior labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants