Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #61369 kubeadm init & join #62451

Merged
merged 7 commits into from
Oct 28, 2022
Merged

Conversation

daro1337
Copy link
Contributor

@daro1337 daro1337 commented Aug 10, 2022

What does this PR do?

What issues does this PR fix or reference?

Fixes: #61369

Previous Behavior

Unable to create k8s (v1.23.X) cluster via salt module

New Behavior

I can create k8s cluster (v1.23.X) via salt module

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@daro1337 daro1337 requested a review from a team as a code owner August 10, 2022 07:41
@daro1337 daro1337 requested review from whytewolf and removed request for a team August 10, 2022 07:41
@welcome
Copy link

welcome bot commented Aug 10, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@whytewolf
Copy link
Collaborator

So, only problem i have with this change is that experimental should not just be dropped off of the command. as it should be deprecated. give users a hey this is going to stop working two versions from now, use this instead. and then change to the non experimental internally.

@whytewolf
Copy link
Collaborator

@daro1337 did you see my note above?

@daro1337
Copy link
Contributor Author

@whytewolf Sorry, I was a bit busy. I will try to add a fix with your suggestion

@daro1337
Copy link
Contributor Author

@whytewolf

I fixed it according to your suggestions. Instead of removing the old argument, I added support for the new one with the appropriate description about the kubeadm version.

@whytewolf
Copy link
Collaborator

alright. so it does need a changelog.

@whytewolf
Copy link
Collaborator

@daro1337 can we get a changelog on this and I"ll approve after that.

@daro1337
Copy link
Contributor Author

@whytewolf done

@garethgreenaway garethgreenaway merged commit 7ccbf93 into saltstack:master Oct 28, 2022
@welcome
Copy link

welcome bot commented Oct 28, 2022

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TECH DEBT] unknown flags experimental_control_plane and experimental_upload_certs in kubeadm v1.23.0
4 participants