Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance zypper install error messages. #62346

Merged
merged 3 commits into from
Sep 20, 2022

Conversation

ycedres
Copy link
Contributor

@ycedres ycedres commented Jul 20, 2022

What does this PR do?

Adds stdout to the error message if zypper install returns with an error code and there is no information on standard error.

What issues does this PR fix or reference?

None.

Previous Behavior

If zypper install returns with an error code and there is no output on standard error, tells the user to check zypper logs.

New Behavior

If zypper install returns with an error code and there is no output on standard error, uses standard output to give more information to the user.

Merge requirements satisfied?

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@ycedres ycedres requested a review from a team as a code owner July 20, 2022 08:43
@ycedres ycedres requested review from krionbsd and removed request for a team July 20, 2022 08:43
@welcome
Copy link

welcome bot commented Jul 20, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

changelog/62346.changed Outdated Show resolved Hide resolved
@ycedres ycedres force-pushed the zyppkg-meaningful-errors branch 2 times, most recently from e67db28 to 880dd32 Compare July 21, 2022 08:04
meaksh
meaksh previously approved these changes Jul 22, 2022
@ycedres ycedres force-pushed the zyppkg-meaningful-errors branch 3 times, most recently from b093eac to 9a38fba Compare July 28, 2022 16:27
@ycedres
Copy link
Contributor Author

ycedres commented Jul 29, 2022

Some checks unrelated to the PR keep failing so I will wait some days to try to run them again.

@ycedres ycedres force-pushed the zyppkg-meaningful-errors branch 2 times, most recently from 05fbfc6 to 6983308 Compare August 22, 2022 07:19
meaksh
meaksh previously approved these changes Aug 22, 2022
@ycedres
Copy link
Contributor Author

ycedres commented Aug 25, 2022

@krionbsd some checks keep failing on this PR that are apparently unrelated to the changes. I've tried forcing a rerun several times and different checks failed each time. Do you have any idea about what could be happening?

Enhance capture of error messages for Zypper calls in zypperpkg module.
@Ch3LL Ch3LL added the P1 Priority 1 label Sep 19, 2022
@ycedres ycedres requested review from meaksh and removed request for krionbsd September 20, 2022 08:24
@Ch3LL Ch3LL merged commit d5dcd14 into saltstack:master Sep 20, 2022
@welcome
Copy link

welcome bot commented Sep 20, 2022

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants