-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance zypper install error messages. #62346
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
e67db28
to
880dd32
Compare
b093eac
to
9a38fba
Compare
Some checks unrelated to the PR keep failing so I will wait some days to try to run them again. |
05fbfc6
to
6983308
Compare
6983308
to
6819d47
Compare
@krionbsd some checks keep failing on this PR that are apparently unrelated to the changes. I've tried forcing a rerun several times and different checks failed each time. Do you have any idea about what could be happening? |
ef668f1
to
9566ff4
Compare
Enhance capture of error messages for Zypper calls in zypperpkg module.
9566ff4
to
6076ad0
Compare
Congratulations on your first PR being merged! 🎉 |
What does this PR do?
Adds stdout to the error message if zypper install returns with an error code and there is no information on standard error.
What issues does this PR fix or reference?
None.
Previous Behavior
If zypper install returns with an error code and there is no output on standard error, tells the user to check zypper logs.
New Behavior
If zypper install returns with an error code and there is no output on standard error, uses standard output to give more information to the user.
Merge requirements satisfied?
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.