-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tcp transport support for ipv6-only hosts #62009
Conversation
@MKLeb Hi, could you merge this, I can't do it myself. |
@MKLeb please merge it. |
Going to pull in the master changes to ensure this runs on the new OS's that have been added |
re-run pr-ubuntu-2004-arm64-py3-pytest |
@garethgreenaway all the required tests have been passed, please merge this PR. |
re-run full all |
re-run pr-centosstream-8-x86_64-py3-pytest |
re-run pr-centos-7-x86_64-py3-pytest |
@garethgreenaway All tests have been successfully completed, merge please. |
re-run pr-ubuntu-2004-amd64-py3-pytest |
re-run pr-freebsd-131-amd64-py3-pytest |
@Ch3LL merge this pr please. |
re-run pr-ubuntu-2004-amd64-py3-pytest |
re-run pr-ubuntu-2004-arm64-py3-pytest |
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - exit code: 1 Thanks again! |
1 similar comment
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - exit code: 1 Thanks again! |
re-run pr-alma-8-x86_64-py3-pytest |
@Ch3LL PTAL |
What does this PR do?
At the moment, the 'tcp' transport only works in ipv4-only mode. This pull request adds ipv6 support.
What issues does this PR fix or reference?
Fixes:
Previous Behavior
masters and minions fail when using the 'tcp' transport in an ipv6-only environment
New Behavior
ipv6-only masters and minions are working properly when using the 'tcp' transport
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.