Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tcp transport support for ipv6-only hosts #62009

Merged
merged 4 commits into from
Jul 19, 2022
Merged

add tcp transport support for ipv6-only hosts #62009

merged 4 commits into from
Jul 19, 2022

Conversation

sakateka
Copy link
Contributor

@sakateka sakateka commented Apr 29, 2022

What does this PR do?

At the moment, the 'tcp' transport only works in ipv4-only mode. This pull request adds ipv6 support.

What issues does this PR fix or reference?

Fixes:

Previous Behavior

masters and minions fail when using the 'tcp' transport in an ipv6-only environment

New Behavior

ipv6-only masters and minions are working properly when using the 'tcp' transport

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@sakateka sakateka requested a review from a team as a code owner April 29, 2022 19:12
@sakateka sakateka requested review from MKLeb and removed request for a team April 29, 2022 19:12
MKLeb
MKLeb previously approved these changes May 11, 2022
@sakateka
Copy link
Contributor Author

@MKLeb Hi, could you merge this, I can't do it myself.

@sakateka
Copy link
Contributor Author

@MKLeb please merge it.

@MKLeb
Copy link
Contributor

MKLeb commented Jun 16, 2022

Going to pull in the master changes to ensure this runs on the new OS's that have been added

@sakateka
Copy link
Contributor Author

re-run pr-ubuntu-2004-arm64-py3-pytest
re-run pr-freebsd-131-amd64-py3-pytest

@sakateka
Copy link
Contributor Author

@garethgreenaway all the required tests have been passed, please merge this PR.

@garethgreenaway
Copy link
Contributor

re-run full all

@sakateka
Copy link
Contributor Author

re-run pr-centosstream-8-x86_64-py3-pytest
re-run pr-centos-7-x86_64-py3-pytest

@sakateka
Copy link
Contributor Author

re-run pr-centos-7-x86_64-py3-pytest

@sakateka
Copy link
Contributor Author

@garethgreenaway All tests have been successfully completed, merge please.

dmurphy18
dmurphy18 previously approved these changes Jun 21, 2022
@sakateka
Copy link
Contributor Author

sakateka commented Jul 3, 2022

re-run pr-ubuntu-2004-amd64-py3-pytest
re-run pr-freebsd-131-amd64-py3-pytest
re-run pr-alma-8-x86_64-py3-pytest

@sakateka
Copy link
Contributor Author

sakateka commented Jul 4, 2022

re-run pr-freebsd-131-amd64-py3-pytest

@sakateka
Copy link
Contributor Author

sakateka commented Jul 7, 2022

@Ch3LL merge this pr please.

@sakateka
Copy link
Contributor Author

sakateka commented Jul 7, 2022

re-run pr-ubuntu-2004-amd64-py3-pytest
re-run pr-freebsd-131-amd64-py3-pytest

@sakateka
Copy link
Contributor Author

sakateka commented Jul 7, 2022

re-run pr-ubuntu-2004-arm64-py3-pytest

salt/utils/zeromq.py Show resolved Hide resolved
@Ch3LL Ch3LL added the Sulfur v3006.0 release code name and version label Jul 7, 2022
@sakateka sakateka dismissed stale reviews from dmurphy18 and MKLeb via 02df408 July 16, 2022 08:20
@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- exit code: 1

/home/runner/.cache/pre-commit/reporg2al9kh/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:33: UserWarning: Setuptools is replacing distutils.
warnings.warn("Setuptools is replacing distutils.")
The function 'check_ipc_path_max_len' on 'salt/utils/zeromq.py' does not have a docstring
Found 1 errors


Thanks again!

1 similar comment
@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- exit code: 1

/home/runner/.cache/pre-commit/reporg2al9kh/py_env-python3/lib/python3.9/site-packages/_distutils_hack/init.py:33: UserWarning: Setuptools is replacing distutils.
warnings.warn("Setuptools is replacing distutils.")
The function 'check_ipc_path_max_len' on 'salt/utils/zeromq.py' does not have a docstring
Found 1 errors


Thanks again!

@sakateka
Copy link
Contributor Author

re-run pr-alma-8-x86_64-py3-pytest
re-run pr-centos-7-x86_64-py3-pycryptodome-pytest

@sakateka sakateka requested a review from Ch3LL July 16, 2022 11:16
@sakateka
Copy link
Contributor Author

@Ch3LL PTAL

@Ch3LL Ch3LL merged commit d22291d into saltstack:master Jul 19, 2022
@sakateka sakateka deleted the transport-tcp-v6 branch July 19, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants