Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt-run saltutil.sync_all doesn't sync roster modules #53914

Closed
max-arnold opened this issue Jul 19, 2019 · 4 comments · Fixed by #62805
Closed

salt-run saltutil.sync_all doesn't sync roster modules #53914

max-arnold opened this issue Jul 19, 2019 · 4 comments · Fixed by #62805
Assignees
@garethgreenaway
Labels
Bug broken, incorrect, or confusing behavior Regression The issue is a bug that breaks functionality known to work in previous releases. severity-high 2nd top severity, seen by most users, causes major problems
Milestone
Sulfur v3006.0

Comments

@max-arnold
Copy link
Contributor

max-arnold commented Jul 19, 2019 •
edited
Loading

Description of Issue

The salt-run saltutil.sync_all command doesn't sync roster modules, although saltutil.sync_roster function exists in the same runner.

https://github.com/saltstack/salt/blob/2017.7/salt/runners/saltutil.py#L39-L61

Versions Report

All versions are affected, starting with 2017.7
@dwoz dwoz added the Bug broken, incorrect, or confusing behavior label Jul 28, 2019
@dwoz dwoz added this to the Approved milestone Jul 28, 2019
@dwoz
Copy link
Contributor

dwoz commented Jul 28, 2019

@max-arnold Thank you for reporting this!

@stale
Copy link

stale bot commented Jan 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 8, 2020
@max-arnold
Copy link
Contributor Author

Still valid

@stale
Copy link

stale bot commented Jan 8, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Jan 8, 2020
@sagetherage sagetherage added Phosphorus v3005.0 Release code name and version severity-high 2nd top severity, seen by most users, causes major problems labels Jun 16, 2021
@sagetherage sagetherage modified the milestones: Approved, Phosphorus Jun 16, 2021
@sagetherage sagetherage added the Regression The issue is a bug that breaks functionality known to work in previous releases. label Jun 16, 2021
@Ch3LL Ch3LL removed the Phosphorus v3005.0 Release code name and version label Mar 30, 2022
@garethgreenaway garethgreenaway self-assigned this Oct 3, 2022
@garethgreenaway garethgreenaway mentioned this issue Oct 3, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garethgreenaway garethgreenaway

Labels
Bug broken, incorrect, or confusing behavior Regression The issue is a bug that breaks functionality known to work in previous releases. severity-high 2nd top severity, seen by most users, causes major problems
Projects
None yet
Milestone
Sulfur v3006.0
Development

Successfully merging a pull request may close this issue.

Run sync_roster when saltutil.sync_all is called garethgreenaway/salt
5 participants
@max-arnold @garethgreenaway @dwoz @Ch3LL @sagetherage