Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python3.7] remove usage of collections.abc stuff from the collections shim #49452

Closed
gtmanfred opened this issue Aug 30, 2018 · 2 comments
Closed

[python3.7] remove usage of collections.abc stuff from the collections shim #49452

gtmanfred opened this issue Aug 30, 2018 · 2 comments
Assignees
@garethgreenaway
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 severity-critical top severity, seen by most users, serious issues severity-high 2nd top severity, seen by most users, causes major problems v2018.3.4 unsupported version ZRELEASED - Fluorine reitred label
Milestone
Approved

Comments

@gtmanfred
Copy link
Contributor

gtmanfred commented Aug 30, 2018 •
edited
Loading

Description of Issue/Question

Implement changes for https://bugs.python.org/issue25988

collections
In Python 3.8, the abstract base classes in collections.abc will no longer be exposed in 
the regular collections module. This will help create a clearer distinction between the
concrete classes and the abstract base classes. (Contributed by Serhiy Storchaka in
 bpo-25988.)
@gtmanfred gtmanfred added the v2018.3.4 unsupported version label Aug 30, 2018
@gtmanfred gtmanfred added this to the Approved milestone Aug 30, 2018
@gtmanfred gtmanfred added severity-critical top severity, seen by most users, serious issues P2 Priority 2 severity-high 2nd top severity, seen by most users, causes major problems Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt TEAM Core ZRELEASED - Fluorine reitred label labels Aug 30, 2018
@rallytime
Copy link
Contributor

@garethgreenaway Can you fix this for 2018.3.4?

@garethgreenaway
Copy link
Contributor

@rallytime On it.

@garethgreenaway garethgreenaway mentioned this issue Sep 2, 2018
Merged
@rallytime rallytime added the fixed-pls-verify fix is linked, bug author to confirm fix label Sep 4, 2018
@gtmanfred gtmanfred mentioned this issue Mar 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garethgreenaway garethgreenaway

Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 severity-critical top severity, seen by most users, serious issues severity-high 2nd top severity, seen by most users, causes major problems v2018.3.4 unsupported version ZRELEASED - Fluorine reitred label
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
3 participants
@garethgreenaway @gtmanfred @rallytime