Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow users to enable "queue=True" for all state runs via config file #31468

Closed
rodriguezsergio opened this issue Feb 24, 2016 · 10 comments · Fixed by #63357
Closed
Labels
Core relates to code central or existential to Salt Feature new functionality including changes to functionality and code refactors, etc.
Milestone

Comments

@rodriguezsergio
Copy link

I'm having issues where a salt state that is already in progress is preventing deploys from occurring because queue is set to False by default.

I noticed that another user had asked for this literally just a few days ago over here, and I was wondering if there is something I can do in the interim.

This is particularly tricky for me because I am using publish.full_data and that is not a supported argument. So unless there is something I haven't found yet, I will have to parse the YAML output and then have to do a retry of sorts to ensure the deploys go out in 1 go and not require user intervention.

$ sudo salt-call publish.full_data "G@ec2tags:csEnv:dev" state.sls general-setup expr_form=compound  --state-output=changes queue=True
The following keyword arguments are not valid: queue=True

https://groups.google.com/forum/#!msg/salt-users/4W1xnzROfas/Jdnlj-J0CwAJ
https://docs.saltstack.com/en/latest/ref/modules/all/salt.modules.publish.html

@rodriguezsergio rodriguezsergio changed the title Enable "queue=True" for all state runs by default Feature Request: Enable "queue=True" for all state runs by default Feb 24, 2016
@tbaker57
Copy link
Contributor

Can you wrap your module call in the 'module' state (https://docs.saltstack.com/en/develop/ref/states/all/salt.states.module.html) and run that state with queue=True ? A hacky workaround I know 😄

cheers,
Tim

@thatch45
Copy link
Contributor

salt-call publish.full_data "G@ec2tags:csEnv:dev" state.sls general-setup expr_form=compound arg='queue=True' --state-output=changes

You are just not using the "arg" argument to pass in queue=True, the above command should work

@thatch45
Copy link
Contributor

I would like to avoid changing this default. It would change default behavior which has been very well established and will throw off many existing users

@thatch45 thatch45 added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Feb 25, 2016
@rodriguezsergio
Copy link
Author

Ah, I should have wrote to allow the user to change the default behavior via some sort of config option in the salt master config.

I've tried running with arg='queue=True' and it returned the following error to me

Passed invalid arguments: full_data() got multiple values for keyword argument 'arg'

$ salt --version
salt 2015.5.5 (Lithium)

@rodriguezsergio rodriguezsergio changed the title Feature Request: Enable "queue=True" for all state runs by default Feature Request: Allow users to enable "queue=True" for all state runs via config file Feb 25, 2016
@thatch45
Copy link
Contributor

I will approve adding the ability to set this in the config. Also, the arg issue you have presented appears to be a bug.

If you want to add this feature yourself it will of course make it available much quicker, take a look at __salt__.config.option to see how it is done

@thatch45 thatch45 added Feature new functionality including changes to functionality and code refactors, etc. and removed Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged labels Feb 25, 2016
@thatch45 thatch45 added this to the Approved milestone Feb 25, 2016
@jfindlay jfindlay added the Core relates to code central or existential to Salt label Feb 25, 2016
@stale
Copy link

stale bot commented Mar 30, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Mar 30, 2018
@stale stale bot closed this as completed Apr 6, 2018
@Oloremo
Copy link
Contributor

Oloremo commented Nov 4, 2019

@Ch3LL can this be re-opened? This is a valid issue and I too would like to have queue=True as a global option.

@waynew waynew removed the stale label Nov 4, 2019
@waynew waynew reopened this Nov 4, 2019
@stale
Copy link

stale bot commented Jan 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 7, 2020
@Oloremo
Copy link
Contributor

Oloremo commented Jan 7, 2020

Not stale

@stale
Copy link

stale bot commented Jan 7, 2020

Thank you for updating this issue. It is no longer marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core relates to code central or existential to Salt Feature new functionality including changes to functionality and code refactors, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants