Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove transport kwarg from get_event #87

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

MKLeb
Copy link
Contributor

@MKLeb MKLeb commented Jan 6, 2022

In anticipation of saltstack/salt#61275

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #87 (5e73d3f) into master (758d8c3) will decrease coverage by 5.93%.
The diff coverage is n/a.

❗ Current head 5e73d3f differs from pull request most recent head 63ac2af. Consider uploading reports for the commit 63ac2af to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   87.58%   81.66%   -5.92%     
==========================================
  Files         101      101              
  Lines        6119     5881     -238     
  Branches      690      686       -4     
==========================================
- Hits         5359     4802     -557     
- Misses        581      878     +297     
- Partials      179      201      +22     
Flag Coverage Δ
Linux ?
Py35 ?
Py36 ?
Py37 81.66% <ø> (-2.55%) ⬇️
Py38 ?
Py39 ?
PyTest60 ?
PyTest61 ?
PyTest62 81.66% <ø> (-5.15%) ⬇️
Salt3002_6 81.62% <ø> (-3.50%) ⬇️
Salt3003 81.66% <ø> (-3.23%) ⬇️
Salt3004 ?
Windows ?
macOS 81.66% <ø> (+0.04%) ⬆️
src 74.55% <ø> (-6.74%) ⬇️
system ?
tests 92.71% <ø> (-2.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ltfactories/utils/saltext/engines/pytest_engine.py 29.10% <ø> (ø)
...tories/daemons/container/test_container_factory.py 25.50% <0.00%> (-70.93%) ⬇️
src/saltfactories/utils/ports.py 55.89% <0.00%> (-29.41%) ⬇️
src/saltfactories/daemons/container.py 28.12% <0.00%> (-24.72%) ⬇️
src/saltfactories/utils/processes.py 67.94% <0.00%> (-21.53%) ⬇️
tests/conftest.py 78.79% <0.00%> (-18.39%) ⬇️
src/saltfactories/daemons/minion.py 78.13% <0.00%> (-17.87%) ⬇️
src/saltfactories/daemons/proxy.py 73.92% <0.00%> (-17.68%) ⬇️
src/saltfactories/daemons/master.py 76.44% <0.00%> (-16.11%) ⬇️
src/saltfactories/plugins/__init__.py 85.72% <0.00%> (-14.28%) ⬇️
... and 57 more

@s0undt3ch s0undt3ch merged commit 7ea36a2 into saltstack:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants