Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes/improvements to the ZMQHandler log forwarding handler #64

Merged
merged 6 commits into from
Jun 16, 2021

Conversation

s0undt3ch
Copy link
Contributor

No description provided.

@waynew
Copy link

waynew commented Jun 14, 2021

This appears to fix the problem I was having with the vmware extension module

@s0undt3ch
Copy link
Contributor Author

This appears to fix the problem I was having with the vmware extension module

Awesome!

@s0undt3ch s0undt3ch force-pushed the master branch 7 times, most recently from 6b5d0bd to b8e1d08 Compare June 16, 2021 16:05
@s0undt3ch s0undt3ch force-pushed the master branch 9 times, most recently from 913c85b to dacbf81 Compare June 16, 2021 18:38
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #64 (2ade6c0) into master (0b416b1) will decrease coverage by 0.94%.
The diff coverage is 37.21%.

❗ Current head 2ade6c0 differs from pull request most recent head 3ca887c. Consider uploading reports for the commit 3ca887c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   61.55%   60.62%   -0.93%     
==========================================
  Files         131      132       +1     
  Lines        7149     7175      +26     
  Branches      819      825       +6     
==========================================
- Hits         4400     4349      -51     
- Misses       2519     2586      +67     
- Partials      230      240      +10     
Flag Coverage Δ
?
Linux 60.17% <37.21%> (-0.54%) ⬇️
factories 80.79% <73.08%> (-0.33%) ⬇️
macOS 75.88% <72.55%> (+0.72%) ⬆️
py36 77.62% <72.55%> (+0.74%) ⬆️
py37 77.72% <72.55%> (+0.74%) ⬆️
py38 60.16% <37.21%> (-0.19%) ⬇️
py39 78.15% <73.08%> (+0.15%) ⬆️
pytest 78.25% <73.08%> (+0.25%) ⬆️
salt_3002_6 78.15% <73.08%> (+0.05%) ⬆️
salt_3003 78.35% <73.08%> (+0.84%) ⬆️
system 44.98% <34.11%> (-0.32%) ⬇️
tests 34.00% <12.99%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/functional/utils/salt/test_log_handlers.py 12.99% <12.99%> (ø)
...ries/utils/salt/log_handlers/pytest_log_handler.py 66.29% <67.45%> (+8.28%) ⬆️
src/saltfactories/plugins/log_server.py 92.31% <100.00%> (-5.90%) ⬇️
src/saltfactories/utils/processes.py 71.43% <0.00%> (-19.54%) ⬇️
src/saltfactories/utils/virtualenv.py 74.29% <0.00%> (-3.80%) ⬇️
src/saltfactories/plugins/sysstats.py 90.10% <0.00%> (-2.97%) ⬇️
src/saltfactories/daemons/minion.py 95.00% <0.00%> (-1.00%) ⬇️
src/saltfactories/utils/markers.py 74.95% <0.00%> (-0.89%) ⬇️
src/saltfactories/bases.py 90.94% <0.00%> (-0.44%) ⬇️
... and 2 more

@s0undt3ch s0undt3ch merged commit e038e0d into saltstack:master Jun 16, 2021
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this pull request Jun 17, 2021
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this pull request Jun 17, 2021
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants