Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the stacklevel of warn_until #127

Closed
s0undt3ch opened this issue Jun 17, 2022 · 0 comments
Closed

Adjust the stacklevel of warn_until #127

s0undt3ch opened this issue Jun 17, 2022 · 0 comments
Assignees
@s0undt3ch
Labels
bug Something isn't working
Milestone
1.0.0

Comments

@s0undt3ch
Copy link
Contributor

When pytest is rewriting, any warn_until calls will report the calling code as pytest's rewrite module.
We need to adjust the stack level in this case to report the offending module properly
@s0undt3ch s0undt3ch added the enhancement New feature or request label Jun 17, 2022
@s0undt3ch s0undt3ch added this to the 1.0.0 milestone Jun 17, 2022
@s0undt3ch s0undt3ch self-assigned this Jun 17, 2022
@s0undt3ch s0undt3ch added bug Something isn't working and removed enhancement New feature or request labels Jun 17, 2022
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Jun 17, 2022
@s0undt3ch
saltfactories.utils.warn_until() is now aware of Pytest's rewrite…
902a7d9 
… calls.

Fixes saltstack#127

Signed-off-by: Pedro Algarvio <[email protected]>
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Jun 17, 2022
@s0undt3ch
saltfactories.utils.warn_until() is now aware of Pytest's rewrite…
f6db085 
… calls.

Fixes saltstack#127

Signed-off-by: Pedro Algarvio <[email protected]>
s0undt3ch added a commit to s0undt3ch/pytest-salt-factories that referenced this issue Jun 17, 2022
@s0undt3ch
saltfactories.utils.warn_until() is now aware of Pytest's rewrite…
f18a4c3 
… calls.

Fixes saltstack#127

Signed-off-by: Pedro Algarvio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s0undt3ch s0undt3ch

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@s0undt3ch