[ssf] ci(travis): run shellcheck during lint job
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myii
changed the title
shellcheck during lint jobshellcheck during lint job
myii
force-pushed
the
chore/standardise-structure-106
branch
from
15ddcac
to
edd5edb
Compare
dafyddj
reviewed
Nov 27, 2019
aboe76
approved these changes
Nov 27, 2019
myii
added a commit
to myii/ssf-formula
that referenced
this pull request
Nov 27, 2019
* Apply suggestion received here: - saltstack-formulas/template-formula#181 (comment)
myii
force-pushed
the
chore/standardise-structure-106
branch
from
edd5edb
to
b1aade4
Compare
* Automated using myii/ssf-formula#106
myii
force-pushed
the
chore/standardise-structure-106
branch
from
b1aade4
to
a711665
Compare
|
Thanks for the reviews/comments, starting the propagation of this now. |
|
🎉 This PR is included in version 3.3.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
myii
pushed a commit
to myii/ssf-formula
that referenced
this pull request
Nov 27, 2019
# [1.63.0](v1.62.0...v1.63.0) (2019-11-27) ### Code Refactoring * **travis:** use pathspecs for `git ls-files` instead of `grep` ([615e3b2](615e3b2)), closes [/github.com/saltstack-formulas/template-formula/pull/181#discussion_r351421463](https://github.com//github.com/saltstack-formulas/template-formula/pull/181/issues/discussion_r351421463) ### Features * **shellcheck:** apply fixes throughout this repo ([1ea7fbb](1ea7fbb)) * **travis:** run `shellcheck` during lint job ([f52eb37](f52eb37)), closes [/github.com/saltstack-formulas/template-formula/pull/180#issuecomment-558612422](https://github.com//github.com/saltstack-formulas/template-formula/pull/180/issues/issuecomment-558612422)
myii
added a commit
to myii/ssf-formula
that referenced
this pull request
Nov 27, 2019
myii
added a commit
to myii/ssf-formula
that referenced
this pull request
Nov 27, 2019
myii
pushed a commit
to myii/ssf-formula
that referenced
this pull request
Nov 27, 2019
## [1.64.1](v1.64.0...v1.64.1) (2019-11-27) ### Bug Fixes * **travis:** quote pathspecs used with `git ls-files` ([be75d2d](be75d2d)), closes [/github.com/saltstack-formulas/template-formula/pull/181#discussion_r351491871](https://github.com//github.com/saltstack-formulas/template-formula/pull/181/issues/discussion_r351491871)
|
Interesting. That explains a lot.
…On Wed, 27 Nov 2019 at 22:39, Imran Iqbal ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#181 (comment)>
:
> @@ -46,6 +46,10 @@ jobs:
# Install and run `rubocop`
- gem install rubocop
- rubocop -d
+ # Run `shellcheck` (already pre-installed in Travis)
+ - shellcheck --version
+ - git ls-files | grep '\.sh$\|\.bash$\|\.ksh$'
Funny, because it worked in the first few formulas I tried! At least you
got to the bottom of that, thanks for sharing.
Actually, this overlaps with the example here, using shopt to keep
nullglob enabled:
- https://github.com/koalaman/shellcheck/wiki/TravisCI
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#181?email_source=notifications&email_token=ABAAGVQP2A7Y2SQ77OHYAZ3QV3ZKRA5CNFSM4JSHEHKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNHX6XI#discussion_r351524122>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAAGVSAAQ6KLYYUU5LLVCTQV3ZKRANCNFSM4JSHEHKA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shellcheckduring lint job myii/ssf-formula#106To be propagated across all formulas using the
ssf-formula. According to our discussions, this only requires one approval, since it's only CI-based changes.Idea started from here:
As
shellcheckis already integrated into Travis, this is easy to run and asides from here, already tested elsewhere:An example of failures (
shellcheckhas excellent error descriptions):