Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOFSv2: Change duplicate use of files; use templates list instead #55

Closed
myii opened this issue Feb 27, 2019 · 3 comments
Closed

TOFSv2: Change duplicate use of files; use templates list instead #55

myii opened this issue Feb 27, 2019 · 3 comments

Comments

@myii
Copy link
Member

myii commented Feb 27, 2019

The current implementation uses files twice.

Here:

# dirs:
# files: files_alt

And here:

# files:
# template-config:
# - 'example_alt.tmpl'
# - 'example_alt.tmpl.jinja'

Since the second one is a list of templates to use, I suggest this is changed to:

    # templates:
    #   template-config:
    #     - 'example_alt.tmpl'
    #     - 'example_alt.tmpl.jinja'

The impact is fairly significant, since this needs to be done throughout:

  1. pillar.example
  2. macros.jinja
  3. TOFS_pattern.md
  4. All formulas that have already adapted to TOFSv2

Since TOFSv2 is very new, this change needs to be brought in ASAP. It hardly can be in use right now but it soon could be.

@myii
Copy link
Member Author

myii commented Feb 27, 2019

@aboe76 Is it too late to make this change in systemd-formula?

@baby-gnu
Copy link
Contributor

baby-gnu commented Apr 3, 2019

I think this is done by #76 and this issue can be closed. No?

@myii
Copy link
Member Author

myii commented Apr 3, 2019

@baby-gnu Yes, thank you!

@myii myii closed this as completed Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants