Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use @oclif/table #635

Merged
merged 8 commits into from
Oct 17, 2024
Merged

feat!: use @oclif/table #635

merged 8 commits into from
Oct 17, 2024

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Oct 1, 2024

BREAKING CHANGE: new table API

Consumers can use convertToNewTableAPI to convert old table input to the new input

@W-16736167@

@iowillhoit iowillhoit requested a review from a team as a code owner October 8, 2024 18:51
...options,
// Don't allow anyone to override these properties
borderStyle: 'headers-only-with-underline',
noStyle: env.getBoolean('SF_NO_TABLE_STYLE', false),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is pretty much what I was picturing with a "screen reader" mode.

src/ux/ux.ts Outdated Show resolved Hide resolved
@mdonnalley mdonnalley merged commit 402831e into main Oct 17, 2024
12 of 46 checks passed
@mdonnalley mdonnalley deleted the mdonnalley/new-table branch October 17, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants