refactor: devScripts update #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
reviewed
Jun 5, 2023
| }) | ||
| ); | ||
| $$.SANDBOX.stub(fs.promises, 'readFile') | ||
| .withArgs('testing') |
There was a problem hiding this comment.
only change readFile for the file you care about
mshanemc
reviewed
Jun 5, 2023
| $$.SANDBOX.stub(fs.promises, 'readFile').resolves(JSON.stringify(readsFile)); | ||
| if (typeof readsFile !== 'boolean') { | ||
| const fsStub = $$.SANDBOX.stub(fs.promises, 'readFile'); | ||
| fsStub.withArgs('parent/child/file.json').resolves(JSON.stringify(readsFile)); |
There was a problem hiding this comment.
only changes readFile for the file it needs to stub. callThrough lets the original implementation work in other cases.
mshanemc
reviewed
Jun 5, 2023
| @@ -163,6 +173,8 @@ describe('org:create:user', () => { | |||
| testOrg.username, | |||
| '--target-dev-hub', | |||
| '[email protected]', | |||
| '--definition-file', | |||
There was a problem hiding this comment.
test says it's testing override of file, but wasn't using the file contents.
WillieRuemmele
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created via github action [skip-validate-pr].
Tests were broken that were stubbing fs.readFile indiscriminately (that's now used during alias stuff in testSteup).
That also uncovered a test that wasn't doing what it said it was, so I also changed the test/assertions