fix: poll npm pack until tarball is available
#185
Conversation
|
|
||
| public async pollForAvailability(checkFn: () => void): Promise<void> { | ||
| const ux = await UX.create(); | ||
| const isNonTTY = process.env.CI !== undefined || process.env.CIRCLECI !== undefined; |
There was a problem hiding this comment.
is process.stdout.isTTY not reliable for CI environments?
There was a problem hiding this comment.
It should work too but haven't tried it, this command is executed by plugin-rel-mgmt.
CI and CIRCLE are built-in env vars in circle: https://circleci.com/docs/2.0/env-vars/#built-in-environment-variables
| const stop = isNonTTY ? (msg: string): UX => ux.log(msg) : (msg: string): void => ux.stopSpinner(msg); | ||
|
|
||
| start('Polling for new version(s) to become available on npm'); | ||
| while (!found && attempts < maxAttempts) { |
There was a problem hiding this comment.
there's a polling client in sfdx-core if you need that much, or the raw (approved) library here: https://github.com/normartin/ts-retry-promise
There was a problem hiding this comment.
Tried using the polling client in sfdx-core but ended up with the same code wrapped inside of it.
We still need to write the promise around this.pack and pass it to sfdx-core.
| await this.pollForAvailability(() => { | ||
| this.pack(registry, options); | ||
| }); | ||
| this.pack(registry, options); |
There was a problem hiding this comment.
@cristiand391 Why are you calling this.pack twice in this function?
Also minor thing, the function name has "Tarball" misspelled
There was a problem hiding this comment.
Since fetchTarball is called in src/lib/installationVerification.ts, every time I ran the tests the polling logic blocked the execution for minutes so to avoid that I moved the polling logic to pollForAvailability and called it in fetchTarball, that way it can be easily stubbed in tests to always resolve the promise.
The second call to this.pack should never be stubbed so it has to be called again after polling for tests to properly work.
What does this PR do?
Adds polling logic to
NpmModule, add new methodfetchTarballthat pollsnpm packuntil the tarball is available.Note:
plugin-rel-mgmt already polls
npm viewin the release process ,npm packis the one failing right afternpm viewsuccessfully retrieves the metadata.Circle logs (signature verification step failed):
plugin-source
toolbelt
Depends on #182
What issues does this PR fix or reference?
@W-10065192@