Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collect perf results on failed command executions #431

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Mar 7, 2023

  • Ensure that performance metrics have been collected when handling failed command executions.
  • Wrap performance metrics in try/catch just to be extra cautious

forcedotcom/cli#1987

@W-12651196@

@mdonnalley mdonnalley requested a review from peternhale March 7, 2023 15:59
@peternhale peternhale merged commit c829946 into main Mar 7, 2023
@peternhale peternhale deleted the mdonnalley/collect-perf-on-failed-executions branch March 7, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants