fix: support hooks for deployRecentValidation and async deploys #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shetzel
approved these changes
May 4, 2021
peternhale
approved these changes
May 4, 2021
| await this.lifecycle.emit('predeploy', cs.toArray()); | ||
| if (this.isAsync) { |
There was a problem hiding this comment.
@WillieRuemmele since this will fail the command, why not move this just after this.isAsync is assigned?
There was a problem hiding this comment.
This is where it should be when async deploys are coded. Unit tests can ensure that the ComponentSetBuilder is called as expected even with it throwing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds postdeploy hook to quickdeploys
adds predeploy hook to async deploys
What issues does this PR fix or reference?
@W-9177575@