fix: add progress bar to deploy #65
Conversation
| }); | ||
|
|
||
| // if SFDX_USE_PROGRESS_BAR is true and no --json flag use progress bar, if not, skip | ||
| if (env.getBoolean('SFDX_USE_PROGRESS_BAR', true) && !this.flags.json) { |
There was a problem hiding this comment.
I thought the default was to use the progress bar?
I've never set SFDX_USE_PROGRESS_BAR on my local but the progress bar does show up.
There was a problem hiding this comment.
@RodEsp that's what this is. If the env var is unset default to true.
There was a problem hiding this comment.
Oh, got'cha. I didn't realize that's what getBoolean did, thanks!
But in that case can we change the comment please?
// if SFDX_USE_PROGRESS_BAR is true or not set and no --json flag use progress bar, otherwise skipThere was a problem hiding this comment.
@RodEsp we're going to merge this as is, but we need to move the progress bar logic and I'll update this comment when I do that
| import { Duration } from '@salesforce/kit'; | ||
| import { asString, asArray, getBoolean, JsonCollection } from '@salesforce/ts-types'; | ||
| import * as chalk from 'chalk'; | ||
| import cli from 'cli-ux'; |
There was a problem hiding this comment.
This is supposed to be available on this when you extend SfdxCommand but it's a different library version. I wonder if we have a story to bump the version in @salesforce/command so we don't have to import the version we need for the progress bar.
| import { SourceCommand } from '../../../sourceCommand'; | ||
|
|
||
| Messages.importMessagesDirectory(__dirname); | ||
| const messages = Messages.loadMessages('@salesforce/plugin-source', 'deploy'); | ||
|
|
||
| type TestLevel = 'NoTestRun' | 'RunSpecifiedTests' | 'RunLocalTests' | 'RunAllTestsInOrg'; |
There was a problem hiding this comment.
This is a type in SDR. We should ask them to export it so we don't have to redefine it.
| }); | ||
|
|
||
| // if SFDX_USE_PROGRESS_BAR is true and no --json flag use progress bar, if not, skip | ||
| if (env.getBoolean('SFDX_USE_PROGRESS_BAR', true) && !this.flags.json) { |
There was a problem hiding this comment.
@RodEsp that's what this is. If the env var is unset default to true.
|
|
||
| it('should NOT call progress bar because of environment variable', async () => { | ||
| try { | ||
| process.env.SFDX_USE_PROGRESS_BAR = 'false'; |
There was a problem hiding this comment.
Nothing wrong with this but jsyk you can stub env.getBoolean instead of wrapping in try/finally
| }); | ||
|
|
||
| // if SFDX_USE_PROGRESS_BAR is true and no --json flag use progress bar, if not, skip | ||
| if (env.getBoolean('SFDX_USE_PROGRESS_BAR', true) && !this.flags.json) { |
There was a problem hiding this comment.
Oh, got'cha. I didn't realize that's what getBoolean did, thanks!
But in that case can we change the comment please?
// if SFDX_USE_PROGRESS_BAR is true or not set and no --json flag use progress bar, otherwise skip
What does this PR do?
Adds a progress bar for
deploywill count the number of components deployed, and tests ranshould behave identically to toolbelt
What issues does this PR fix or reference?
@W-9014708@