feat: support split custom labels #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amphro
reviewed
Apr 6, 2021
| '<fullName>force_app_Label_2</fullName>' | ||
| ); | ||
| // Skipping if using sfdx executable because it does not support multiple CustomLabels files on retrieve | ||
| (EXECUTABLE.includes('plugin-source') ? describe : describe.skip)('CustomLabels', () => { |
amphro
approved these changes
Apr 6, 2021
mdonnalley
force-pushed
the
mdonnalley/custom-labels
branch
from
091c1f9 to
090f510
Compare
WillieRuemmele
approved these changes
Apr 13, 2021
| @@ -265,18 +265,16 @@ describe('SourceCommand', () => { | |||
| const compSet = await command.callCreateComponentSet(options); | |||
| expect(fromManifestStub.calledOnce).to.equal(true); | |||
| expect(fromManifestStub.firstCall.args[0]).to.equal(options.manifest); | |||
| expect(fromManifestStub.firstCall.args[1]).to.deep.equal({ resolve: packageDir1 }); | |||
| expect(fromManifestStub.firstCall.args[1]).to.deep.equal({ resolve: [packageDir1] }); | |||
There was a problem hiding this comment.
@mdonnalley the SDRL had some breaking changes, so I updated the createComponentSet to use the new methods, which resulted in changes here and retrieve.test.ts could you verify this still is correct
mdonnalley
force-pushed
the
mdonnalley/custom-labels
branch
from
5ba0caa to
4269f61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supports CustomLabels split across multiple package directories
What issues does this PR fix or reference?
@W-9016030@