fix: missing metadata type error matches toolbelt #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
approved these changes
Jul 27, 2021
| csAggregator.push(...finalized); | ||
| } | ||
| } catch (e) { | ||
| if ((e as Error).message.includes('Missing metadata type definition in registry for id')) { |
There was a problem hiding this comment.
Are we logging this via telemetry (it could be that the regular exception logging picks them up ok)
If not, it'd be great to have these as a type of exception, with the mdtype(s) in there, so we can use that data to help MD owners know customers are trying to deploy their feature AND help us prioritize support gaps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
catches and transforms the SDR error for a missing metadata type to match the toolbelt's
should hopefully defer blame to the user rather than us
What issues does this PR fix or reference?
@W-9657211@