fix: retrieve package names output #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shetzel
reviewed
Jul 19, 2021
| const formatterOptions = { | ||
| waitTime: this.getFlag<Duration>('wait').quantity, | ||
| verbose: this.getFlag<boolean>('verbose', false), | ||
| }; | ||
| const formatter = new RetrieveResultFormatter(this.logger, this.ux, formatterOptions, this.retrieveResult); | ||
| formatter.packages = packages; |
There was a problem hiding this comment.
What do you think about changing the formatterOptions type to add an optional packages option instead?
There was a problem hiding this comment.
I was doing that at first, but that type is defined in the ResultFormatter class, which is a base class for deploy and retrieve, but retrieve only has packagenames. It felt awkward altering the base class for only one of the child classes... but I'm open to doing that way too
There was a problem hiding this comment.
Why can't we do this:
export interface RetrieveResultFormatterOptions extends ResultFormatterOptions {
packages?: string;
}and then:
public constructor(logger: Logger, ux: UX, options: RetrieveResultFormatterOptions, result: RetrieveResult) {
shetzel
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes retrieves with package name's output to list the package name, path, and source retrieved into that dir
matches toolbelt with the package section and JSON
differs from toolbelt by including the
Retrieved SourcesectionWhat issues does this PR fix or reference?
@W-9584557@