fix: temporary polling fix #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
approved these changes
Jun 15, 2021
| while (!complete) { | ||
| const status = await mdapiRetrieve.checkStatus(); | ||
| if (totalTimeMs >= this.getFlag<Duration>('wait').milliseconds) { | ||
| throw SfdxError.create('@salesforce/plugin-source', 'retrieve', 'retrieveTimeout', [ |
There was a problem hiding this comment.
I haven't really looked in what SDR is doing, but I'm remembering we wanted to set a particular exit code (69? 70?) for timeouts and give the user something they could do [retry the deploy? check the status?]. If SDR isn't handling that, you might want to catch your error.
There was a problem hiding this comment.
The message Your retrieve request did not complete within the specified wait time [1 minutes]. Try again with a longer wait time. already suggests increasing the timeout with --wait
I'll set the exit code to 69 - coming from https://salesforce.quip.com/JoC2A2IlF9a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
temp workaround for polling bug in core/SDR
What issues does this PR fix or reference?
@W-9472869@