Skip to content

Commit

Permalink
Merge pull request #949 from salesforcecli/cd/rm-unused-jsforce-files
Browse files Browse the repository at this point in the history
fix: remove unused jsforce stuff
  • Loading branch information
iowillhoit authored Nov 29, 2023
2 parents ed2ff85 + ec982f3 commit 547ee24
Showing 1 changed file with 15 additions and 3 deletions.
18 changes: 15 additions & 3 deletions src/commands/cli/tarballs/prepare.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,21 @@ export default class Prepare extends SfCommand<void> {
const nycOutput = await find(`${baseDirGlob}/**/.nyc_output`);
this.remove(nycOutput, '.nyc_output files');

// Large files shipped with jsforce
const jsforceBuild = await find(`${baseDirGlob}/jsforce/build`, { onlyDirectories: true });
this.remove(jsforceBuild, 'jsforce/build directory');
// START TODO: delete after `sf` moves to `jsforce-node`
// Delete large files shipped with jsforce
//
// Browser bundles
const jsforceBuild = await find(`${baseDirGlob}/jsforce/dist`, { onlyDirectories: true });
this.remove(jsforceBuild, 'jsforce/dist directory');

// TS source code
const jsforceSrc = await find(`${baseDirGlob}/jsforce/src`, { onlyDirectories: true });
this.remove(jsforceSrc, 'jsforce/src directory');

// ESM browser build
const jsforceESMBrowserBuild = await find(`${baseDirGlob}/jsforce/browser`, { onlyDirectories: true });
this.remove(jsforceESMBrowserBuild, 'jsforce/browser directory');
// END

// This breaks compilation. We need to probably do this right before the pack, but then this will
// break compilation the next time compile is ran without doing a yarn install --force
Expand Down

0 comments on commit 547ee24

Please sign in to comment.