You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ravijayaramappa let's validate what locker does for srcElement and path property, and the composedPath() method. If locker can protect us until 220, then we should do that.
The raw value is filtered to apply namespace rules and then wrapped in a SecureElement
Customers could be using it. Higher chance of a regression if locker blocks it without notice.
path
Property is exposed
The raw array is wrapped in a proxy. On access, array values are filtered to apply namespace rules and either wrapped in a SecureElement or an opaque(no properties) object
This one should be low risk to block in locker. Since this is a non-standard property, chances of a customer regression is low.
User story for Locker to assess this property W-5694860
composedPath()
Property is exposed but has never worked as expected. It does not work because the property is exposed incorrectly.
This one should be low risk to block in locker because it has never worked. So chances of customer regression is very low. There might be customers who have sniffing if a such a property exists on an event, but nothing beyond that.
User story for Locker to assess this property W-5694762
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
event.composedPath()
event.path
=> getter alias for .composedPath()event.srcElement
=> non-standard that is everywhere (thanks to IE)Does this PR introduce a breaking change?