Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wire-service): upgrade playground #673

Merged
merged 1 commit into from
Sep 25, 2018
Merged

fix(wire-service): upgrade playground #673

merged 1 commit into from
Sep 25, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Sep 25, 2018

Details

Upgrade wire-service playground to the latests.

@diervo diervo requested a review from kevinv11n September 25, 2018 06:37
kevinv11n
kevinv11n reviewed Sep 25, 2018
View reviewed changes
Copy link
Contributor

@kevinv11n kevinv11n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing all those components? They’re used by x-demo

@diervo
Copy link
Contributor Author

diervo commented Sep 25, 2018

Something weird happened it was supposed to be a rename!

@diervo diervo force-pushed the dval/upgradeWirePkg branch from b1dccbd to a82f498 Compare September 25, 2018 16:14
@diervo diervo merged commit c5d3e80 into master Sep 25, 2018
@diervo diervo deleted the dval/upgradeWirePkg branch September 25, 2018 21:04
@kevinv11n
Copy link
Contributor

Thanks for fixing this, @diervo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinv11n kevinv11n kevinv11n left review comments

@pmdartus pmdartus pmdartus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diervo @kevinv11n @pmdartus