Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): allowing global listeners #404

Merged
merged 1 commit into from
Jun 13, 2018
Merged

fix(engine): allowing global listeners #404

merged 1 commit into from
Jun 13, 2018

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Jun 12, 2018

Details

  • Supporting access to patched events asynchronously.
  • Applying shadow dom semantics when accessing a patched event asynchronously.
  • Remove proxy from currentTarget and target when listened for outside of the shadow (global events).

Does this PR introduce a breaking change?

  • Yes

@caridy caridy requested a review from davidturissini June 12, 2018 22:51
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: f3887ec | Target commit: 012fccf

This was referenced Jun 12, 2018
Closed
Closed
@diervo diervo merged commit da2d3c7 into master Jun 13, 2018
@diervo diervo deleted the caridy/global-events-and-async-events branch June 13, 2018 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidturissini davidturissini Awaiting requested review from davidturissini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caridy @diervo