fix: rollup-plugin module resolve when rootDir is a relative path #1471
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default @lwc/rollup-plugin try to find the modules in the same directory of the entry. Some times this is not enough and you need to specify the root directory of the lwc modules (rootDir option) When the rootDir is present and is a relative path, it will not work, even if is correct relative to the process.cwd() This pr normalizes the rootDir option by doing a path.resolve(rootDir)
diervo
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
By default
@lwc/rollup-plugintry to find the modules in the same directory of the entry. Some times this is not enough and you need to specify the root directory of the lwc modules (rootDir option)When the rootDir is present and is a relative path, it will not work, even if is correct relative to the
process.cwd()This pr normalize the rootDir option by doing a
path.resolve(rootDir)Does this PR introduce breaking changes?
No, it does not introduce breaking changes.