Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(synthetic-shadow): shadow semantics for tabindex #1255

Merged
merged 1 commit into from
May 22, 2019

Conversation

ekashida
Copy link
Member

This reverts commit 040c22a.

Details

Implements shadow semantics for tabindex.

Does this PR introduce a breaking change?

No

@ekashida ekashida changed the title fix(synthetic-shadow): prevent tabbing into tabindex -1 subtrees fix(synthetic-shadow): shadow semantics for tabindex May 22, 2019
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 34dd4b9 | Target commit: 0a2c57b

lwc-engine-benchmark

table-append-1k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table/append/1k duration 140.90 (±2.45 ms) 139.55 (±4.80 ms) -1.3ms (1.0%) 👍
table-clear-1k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table/clear/1k duration 10.65 (±0.85 ms) 10.20 (±0.90 ms) -0.4ms (4.2%) 👌
table-create-10k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table/create/10k duration 859.10 (±7.40 ms) 854.90 (±6.45 ms) -4.2ms (0.5%) 👍
table-create-1k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table/create/1k duration 108.40 (±2.90 ms) 106.50 (±2.80 ms) -1.9ms (1.8%) 👍
table-update-10th-1k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table/update-10th/1k duration 68.00 (±2.05 ms) 74.75 (±3.60 ms) +6.8ms (9.9%) 👎
tablecmp-append-1k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table-component/append/1k duration 223.90 (±7.45 ms) 214.60 (±13.90 ms) -9.3ms (4.2%) 👍
tablecmp-clear-1k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table-component/clear/1k duration 6.70 (±1.25 ms) 6.55 (±1.20 ms) -0.1ms (2.2%) 👌
tablecmp-create-10k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table-component/create/10k duration 1621.90 (±11.20 ms) 1593.40 (±12.90 ms) -28.5ms (1.8%) 👍
tablecmp-create-1k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table-component/create/1k duration 181.95 (±3.60 ms) 181.35 (±4.95 ms) -0.6ms (0.3%) 👌
tablecmp-update-10th-1k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table-component/update-10th/1k duration 65.20 (±5.00 ms) 66.75 (±5.10 ms) +1.5ms (2.4%) 👌
wc-append-1k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table-wc/append/1k duration 234.05 (±12.45 ms) 235.85 (±12.25 ms) +1.8ms (0.8%) 👌
wc-clear-1k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table-wc/clear/1k duration 11.60 (±1.80 ms) 12.05 (±1.60 ms) +0.5ms (3.9%) 👌
wc-create-10k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table-wc/create/10k duration 1790.10 (±9.00 ms) 1749.60 (±12.30 ms) -40.5ms (2.3%) 👍
wc-create-1k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table-wc/create/1k duration 196.65 (±5.60 ms) 198.25 (±4.05 ms) +1.6ms (0.8%) 👌
wc-update-10th-1k metric base(34dd4b9) target(0a2c57b) trend
benchmark-table-wc/update-10th/1k duration 66.35 (±5.70 ms) 65.35 (±4.35 ms) -1.0ms (1.5%) 👌

@ekashida ekashida merged commit 5eeb2a1 into master May 22, 2019
@ekashida ekashida deleted the ekashida/fix-tabindex-tabbing branch May 22, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants