Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-plugin-component): validate wire adapter import #1096

Merged
merged 2 commits into from
Mar 7, 2019

Conversation

apapko
Copy link
Collaborator

@apapko apapko commented Mar 6, 2019

Details

Decorator validation throws an error if wire adapter has not been imported ( W-5777999 ). This fix adds extra validation on the import path.

Does this PR introduce a breaking change?

  • Yes
  • No

@apapko apapko added the bug label Mar 6, 2019
@apapko apapko requested a review from pmdartus March 6, 2019 18:29
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 7a4c15d | Target commit: a298175

lwc-engine-benchmark

table-append-1k metric base(7a4c15d) target(a298175) trend
benchmark-table/append/1k duration 154.65 (±4.55 ms) 155.50 (±4.80 ms) +0.8ms (0.5%) 👌
table-clear-1k metric base(7a4c15d) target(a298175) trend
benchmark-table/clear/1k duration 11.10 (±0.60 ms) 11.10 (±0.65 ms) 0.0ms (0.0%) 👌
table-create-10k metric base(7a4c15d) target(a298175) trend
benchmark-table/create/10k duration 893.35 (±6.15 ms) 879.35 (±6.75 ms) -14.0ms (1.6%) 👍
table-create-1k metric base(7a4c15d) target(a298175) trend
benchmark-table/create/1k duration 120.00 (±2.95 ms) 121.90 (±3.05 ms) +1.9ms (1.6%) 👎
table-update-10th-1k metric base(7a4c15d) target(a298175) trend
benchmark-table/update-10th/1k duration 75.55 (±2.85 ms) 75.00 (±2.15 ms) -0.5ms (0.7%) 👌
tablecmp-append-1k metric base(7a4c15d) target(a298175) trend
benchmark-table-component/append/1k duration 228.40 (±12.70 ms) 224.45 (±11.25 ms) -3.9ms (1.7%) 👌
tablecmp-clear-1k metric base(7a4c15d) target(a298175) trend
benchmark-table-component/clear/1k duration 5.65 (±0.75 ms) 6.35 (±1.05 ms) +0.7ms (12.4%) 👌
tablecmp-create-10k metric base(7a4c15d) target(a298175) trend
benchmark-table-component/create/10k duration 1769.35 (±13.40 ms) 1780.10 (±11.30 ms) +10.8ms (0.6%) 👎
tablecmp-create-1k metric base(7a4c15d) target(a298175) trend
benchmark-table-component/create/1k duration 213.60 (±5.35 ms) 216.20 (±6.70 ms) +2.6ms (1.2%) 👎
tablecmp-update-10th-1k metric base(7a4c15d) target(a298175) trend
benchmark-table-component/update-10th/1k duration 69.95 (±4.90 ms) 70.45 (±5.60 ms) +0.5ms (0.7%) 👌
wc-append-1k metric base(7a4c15d) target(a298175) trend
benchmark-table-wc/append/1k duration 232.30 (±16.65 ms) 233.30 (±19.25 ms) +1.0ms (0.4%) 👌
wc-clear-1k metric base(7a4c15d) target(a298175) trend
benchmark-table-wc/clear/1k duration 10.90 (±1.85 ms) 11.50 (±1.40 ms) +0.6ms (5.5%) 👌
wc-create-10k metric base(7a4c15d) target(a298175) trend
benchmark-table-wc/create/10k duration 1918.85 (±10.85 ms) 1948.15 (±11.95 ms) +29.3ms (1.5%) 👎
wc-create-1k metric base(7a4c15d) target(a298175) trend
benchmark-table-wc/create/1k duration 219.40 (±5.60 ms) 227.30 (±5.35 ms) +7.9ms (3.6%) 👎
wc-update-10th-1k metric base(7a4c15d) target(a298175) trend
benchmark-table-wc/update-10th/1k duration 71.25 (±6.05 ms) 70.95 (±7.05 ms) -0.3ms (0.4%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: 7a4c15d | Target commit: 09862b5

lwc-engine-benchmark

table-append-1k metric base(7a4c15d) target(09862b5) trend
benchmark-table/append/1k duration 154.65 (±4.55 ms) 151.85 (±4.60 ms) -2.8ms (1.8%) 👌
table-clear-1k metric base(7a4c15d) target(09862b5) trend
benchmark-table/clear/1k duration 11.10 (±0.60 ms) 10.85 (±0.60 ms) -0.2ms (2.3%) 👌
table-create-10k metric base(7a4c15d) target(09862b5) trend
benchmark-table/create/10k duration 893.35 (±6.15 ms) 893.40 (±8.05 ms) +0.0ms (0.0%) 👌
table-create-1k metric base(7a4c15d) target(09862b5) trend
benchmark-table/create/1k duration 120.00 (±2.95 ms) 119.00 (±2.50 ms) -1.0ms (0.8%) 👌
table-update-10th-1k metric base(7a4c15d) target(09862b5) trend
benchmark-table/update-10th/1k duration 75.55 (±2.85 ms) 84.50 (±4.40 ms) +9.0ms (11.8%) 👎
tablecmp-append-1k metric base(7a4c15d) target(09862b5) trend
benchmark-table-component/append/1k duration 228.40 (±12.70 ms) 227.20 (±8.55 ms) -1.2ms (0.5%) 👌
tablecmp-clear-1k metric base(7a4c15d) target(09862b5) trend
benchmark-table-component/clear/1k duration 5.65 (±0.75 ms) 6.30 (±1.10 ms) +0.6ms (11.5%) 👌
tablecmp-create-10k metric base(7a4c15d) target(09862b5) trend
benchmark-table-component/create/10k duration 1769.35 (±13.40 ms) 1766.60 (±12.80 ms) -2.8ms (0.2%) 👌
tablecmp-create-1k metric base(7a4c15d) target(09862b5) trend
benchmark-table-component/create/1k duration 213.60 (±5.35 ms) 221.90 (±5.30 ms) +8.3ms (3.9%) 👎
tablecmp-update-10th-1k metric base(7a4c15d) target(09862b5) trend
benchmark-table-component/update-10th/1k duration 69.95 (±4.90 ms) 69.45 (±3.65 ms) -0.5ms (0.7%) 👌
wc-append-1k metric base(7a4c15d) target(09862b5) trend
benchmark-table-wc/append/1k duration 232.30 (±16.65 ms) 232.65 (±17.55 ms) +0.3ms (0.2%) 👌
wc-clear-1k metric base(7a4c15d) target(09862b5) trend
benchmark-table-wc/clear/1k duration 10.90 (±1.85 ms) 11.05 (±1.65 ms) +0.2ms (1.4%) 👌
wc-create-10k metric base(7a4c15d) target(09862b5) trend
benchmark-table-wc/create/10k duration 1918.85 (±10.85 ms) 1926.25 (±14.65 ms) +7.4ms (0.4%) 👌
wc-create-1k metric base(7a4c15d) target(09862b5) trend
benchmark-table-wc/create/1k duration 219.40 (±5.60 ms) 222.45 (±4.90 ms) +3.0ms (1.4%) 👌
wc-update-10th-1k metric base(7a4c15d) target(09862b5) trend
benchmark-table-wc/update-10th/1k duration 71.25 (±6.05 ms) 70.95 (±5.05 ms) -0.3ms (0.4%) 👌

@apapko apapko merged commit e3525d5 into master Mar 7, 2019
@apapko apapko deleted the apapko/wire-adapter-import branch March 7, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants