Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEF can hang during Eclipse workspace re-open due to Bazel command hang #144

Closed
plaird opened this issue Jun 29, 2020 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@plaird
Copy link
Contributor

plaird commented Jun 29, 2020

Sometimes BEF will hang on re-open of an existing workspace because a Bazel command never returns.

        int exitCode = process.waitFor();

https://github.com/salesforce/bazel-eclipse/blob/master/plugin-libs/plugin-command/src/main/java/com/salesforce/bazel/eclipse/command/shell/ShellCommand.java#L129

Bazel commands are single threaded. Only one command can run at a time. Perhaps a command is stuck, and so the whole thing halts. We should be specifying a timeout into the waitFor() invocation. But that timeout needs to be configurable because whatever value we pick probably won't work for some huge package.

https://stackoverflow.com/questions/5483830/process-waitfor-never-returns

@plaird plaird added the bug Something isn't working label Jun 29, 2020
@plaird
Copy link
Contributor Author

plaird commented Oct 8, 2020

I can no longer reproduce this. We have done some optimizations of the import/classpath code, perhaps we fixed this without knowing it.

@plaird plaird closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant